Only pass the outer scope info with ParseInfo

Only pass the outer scope info with ParseInfo

We don't need the context anymore for parsing, the scope info chain is
enough.

BUG=v8:5215
R=marja@chromium.org,jgruber@chromium.org,mstarzinger@chromium.org

Committed: https://crrev.com/65aa596f1e6ac9df45291cde0e7dd107bf2b3ede
Cr-Commit-Position: refs/heads/master@{#39457}

[jochen (gone - plz use gerrit), 2016-09-14 11:30:14]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 11:30:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-09-14 11:32:04]

https://codereview.chromium.org/2342443004/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (left):

https://codereview.chromium.org/2342443004/diff/1/src/ast/scopes.cc#oldcode380
src/ast/scopes.cc:380: DCHECK_IMPLIES(
all those DCHECKs only checked that the context chain and the scope info chain
are equivalent.

[marja, 2016-09-14 11:37:28]

lgtm

[marja, 2016-09-14 11:37:44]

... and forgot to nit about the typo in the description: chain

[jochen (gone - plz use gerrit), 2016-09-14 11:38:49]

Description was changed from

==========
Only pass the outer scope info with ParseInfo

We don't need the context anymore for parsing, the scope info chai is
enough.

BUG=v8:5215
R=marja@chromium.org,jgruber@chromium.org,mstarzinger@chromium.org
==========

to

==========
Only pass the outer scope info with ParseInfo

We don't need the context anymore for parsing, the scope info chain is
enough.

BUG=v8:5215
R=marja@chromium.org,jgruber@chromium.org,mstarzinger@chromium.org
==========

[jgruber, 2016-09-14 11:44:56]

lgtm

https://codereview.chromium.org/2342443004/diff/1/src/parsing/parse-info.h
File src/parsing/parse-info.h (right):

https://codereview.chromium.org/2342443004/diff/1/src/parsing/parse-info.h#ne...
src/parsing/parse-info.h:168: void set_outer_scope_info(Handle<ScopeInfo>
outer_scope_info) {
Since this is always called with the same 

if (!context->IsNativeContext()) {
  parse_info.set_outer_scope_info(handle(context->scope_info()));
}

pattern, maybe it'd be nice to encapsulate this into something like
MaybeSetOuterScopeInfoFrom(context)?

[jochen (gone - plz use gerrit), 2016-09-14 11:48:34]

https://codereview.chromium.org/2342443004/diff/1/src/parsing/parse-info.h
File src/parsing/parse-info.h (right):

https://codereview.chromium.org/2342443004/diff/1/src/parsing/parse-info.h#ne...
src/parsing/parse-info.h:168: void set_outer_scope_info(Handle<ScopeInfo>
outer_scope_info) {
On 2016/09/14 at 11:44:56, jgruber wrote:
> Since this is always called with the same 
> 
> if (!context->IsNativeContext()) {
>   parse_info.set_outer_scope_info(handle(context->scope_info()));
> }
> 
> pattern, maybe it'd be nice to encapsulate this into something like
MaybeSetOuterScopeInfoFrom(context)?

eventually, the compiler dispatcher will only have a shared function info and no
context, and we can also use this for generating debug code without a context.

[commit-bot: I haz the power, 2016-09-14 12:17:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 12:17:03]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-09-14 16:03:08]

jochen@chromium.org changed reviewers:
+ adamk@chromium.org

[jochen (gone - plz use gerrit), 2016-09-14 16:03:09]

+adamk fyi

[jochen (gone - plz use gerrit), 2016-09-15 18:16:07]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-09-15 18:16:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 18:17:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 18:17:46]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[jochen (gone - plz use gerrit), 2016-09-15 19:18:25]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-09-15 19:18:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
jgruber@chromium.org, marja@chromium.org
Link to the patchset: https://codereview.chromium.org/2342443004/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-15 19:18:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 19:47:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-15 19:47:42]

Description was changed from

==========
Only pass the outer scope info with ParseInfo

We don't need the context anymore for parsing, the scope info chain is
enough.

BUG=v8:5215
R=marja@chromium.org,jgruber@chromium.org,mstarzinger@chromium.org
==========

to

==========
Only pass the outer scope info with ParseInfo

We don't need the context anymore for parsing, the scope info chain is
enough.

BUG=v8:5215
R=marja@chromium.org,jgruber@chromium.org,mstarzinger@chromium.org

Committed: https://crrev.com/65aa596f1e6ac9df45291cde0e7dd107bf2b3ede
Cr-Commit-Position: refs/heads/master@{#39457}
==========

[commit-bot: I haz the power, 2016-09-15 19:47:43]

Patchset 2 (id:??) landed as
https://crrev.com/65aa596f1e6ac9df45291cde0e7dd107bf2b3ede
Cr-Commit-Position: refs/heads/master@{#39457}