Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/modules/webusb/USBConnectionEventInit.idl

Issue 2342393002: Enable TypeError for dictionary members of non-nullable interface type (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/webmidi/MIDIMessageEventInit.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webusb/USBConnectionEventInit.idl
diff --git a/third_party/WebKit/Source/modules/webusb/USBConnectionEventInit.idl b/third_party/WebKit/Source/modules/webusb/USBConnectionEventInit.idl
index 797cf732cf16690c06387d4751b20ece87702fa7..78433c40da88eb4a3c1cbbcb0c8477f31ddc9289 100644
--- a/third_party/WebKit/Source/modules/webusb/USBConnectionEventInit.idl
+++ b/third_party/WebKit/Source/modules/webusb/USBConnectionEventInit.idl
@@ -5,5 +5,8 @@
// http://wicg.github.io/webusb/#events
dictionary USBConnectionEventInit : EventInit {
- USBDevice device;
+ // TODO(foolip): |device| should be required and not nullable.
+ // https://crbug.com/647693
+ // https://github.com/WICG/webusb/issues/63
+ USBDevice? device;
};
« no previous file with comments | « third_party/WebKit/Source/modules/webmidi/MIDIMessageEventInit.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698