third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl - Issue 2342393002: Enable TypeError for dictionary members of non-nullable interface type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl

Issue 2342393002: Enable TypeError for dictionary members of non-nullable interface type (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEventInit.idl ('k') | third_party/WebKit/Source/modules/speech/SpeechRecognitionEvent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl

index 629bd1aabf39ff316ad82f711595736eede71b88..9db9060525ff1383e3a863e8759f07dee743b5d3 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl

+++ b/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl

@@ -2,10 +2,11 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#dictdef-foreignfetchevent-foreignfetchresponse

+// https://w3c.github.io/ServiceWorker/#dictdef-foreignfetchevent-foreignfetchresponse

dictionary ForeignFetchResponse {

- required Response response;

+ // TODO(foolip): |response| should not be nullable. https://crbug.com/647693

+ required Response? response;

USVString origin;

sequence<ByteString> headers;

};