third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl - Issue 2342393002: Enable TypeError for dictionary members of non-nullable interface type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl

Issue 2342393002: Enable TypeError for dictionary members of non-nullable interface type (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/MediaStreamEventInit.idl ('k') | third_party/WebKit/Source/modules/presentation/PresentationConnectionAvailableEventInit.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl b/third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl

index 79ab16bbd792c2a4c943c1189d1873393451f886..a7c1fbce4f52a2aef7fbcd4542e5c88ba029ea80 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl

+++ b/third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl

@@ -5,6 +5,8 @@

// https://notifications.spec.whatwg.org/#notificationevent

dictionary NotificationEventInit : ExtendableEventInit {

- required Notification notification;

+ // TODO(foolip): |notification| should not be nullable.

+ // https://crbug.com/647693

+ required Notification? notification;

DOMString action = "";

};