[Sync] NonBlocking type registration clear instead of crashes when also registered as pssive.

[Sync] NonBlocking type registration clear instead of crashes when also registered as pssive.

BUG=634388
Committed: https://crrev.com/49c3f34edcbac33f3ad22dad393a6dfd2123c645
Cr-Commit-Position: refs/heads/master@{#419892}

[skym, 2016-09-16 22:45:54]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[skym, 2016-09-16 22:46:32]

Description was changed from

==========
[Sync] NonBlocking type registration clear instead of crashes when also
registered as pssive.

BUG=634388
==========

to

==========
[Sync] NonBlocking type registration clear instead of crashes when also
registered as pssive.

BUG=634388
==========

[skym, 2016-09-16 22:46:32]

skym@chromium.org changed reviewers:
+ gangwu@chromium.org, maxbogue@chromium.org, pavely@chromium.org

[commit-bot: I haz the power, 2016-09-16 22:46:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2016-09-16 22:46:53]

PTAL

[skym, 2016-09-16 22:50:55]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 22:51:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2016-09-16 22:51:18]

Fixing upload.

https://codereview.chromium.org/2342353004/diff/1/components/sync/driver/glue...
File components/sync/driver/glue/sync_backend_registrar.cc (right):

https://codereview.chromium.org/2342353004/diff/1/components/sync/driver/glue...
components/sync/driver/glue/sync_backend_registrar.cc:70: //
last_configured_types_.Remove(type);
Whhhhooops. Was making sure that commenting this line out broke unit tests, and
somehow it made it into uploaded copy. Fixing.

[commit-bot: I haz the power, 2016-09-16 23:01:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 23:01:36]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[skym, 2016-09-16 23:27:35]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 23:27:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 00:23:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 00:23:50]

Dry run: This issue passed the CQ dry run.

[pavely, 2016-09-20 01:06:52]

Sky, could you change the logic with assumption that SetInitialTypes is always
called before RegisterNonBlockingType. Your changes in RegisterNonBlockingType
will stay the same, code in SetInitialTypes should check that
non_blocking_types_ is empty and then put all types into passive group. You'll
need to switch order of calls to these functions in unittest.

[skym, 2016-09-20 17:24:52]

On 2016/09/20 01:06:52, pavely wrote:
> Sky, could you change the logic with assumption that SetInitialTypes is always
> called before RegisterNonBlockingType. Your changes in RegisterNonBlockingType
> will stay the same, code in SetInitialTypes should check that
> non_blocking_types_ is empty and then put all types into passive group. You'll
> need to switch order of calls to these functions in unittest.

We talked about this in person. Lets leave it like this for now, knowing that
there are refactorings in our near future, even though the chances of changing
the SetInitialTypes -> RegisterNonBlockingType ordering is slim.

[pavely, 2016-09-20 18:11:19]

lgtm

[skym, 2016-09-20 19:18:42]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2016-09-20 19:19:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 19:56:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 19:56:29]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[skym, 2016-09-20 19:57:35]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2016-09-20 19:57:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 20:05:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 20:05:03]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[skym, 2016-09-20 22:15:42]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2016-09-20 22:16:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 23:15:05]

Description was changed from

==========
[Sync] NonBlocking type registration clear instead of crashes when also
registered as pssive.

BUG=634388
==========

to

==========
[Sync] NonBlocking type registration clear instead of crashes when also
registered as pssive.

BUG=634388
==========

[commit-bot: I haz the power, 2016-09-20 23:15:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-20 23:17:19]

Description was changed from

==========
[Sync] NonBlocking type registration clear instead of crashes when also
registered as pssive.

BUG=634388
==========

to

==========
[Sync] NonBlocking type registration clear instead of crashes when also
registered as pssive.

BUG=634388

Committed: https://crrev.com/49c3f34edcbac33f3ad22dad393a6dfd2123c645
Cr-Commit-Position: refs/heads/master@{#419892}
==========

[commit-bot: I haz the power, 2016-09-20 23:17:20]

Patchset 3 (id:??) landed as
https://crrev.com/49c3f34edcbac33f3ad22dad393a6dfd2123c645
Cr-Commit-Position: refs/heads/master@{#419892}