Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2342353003: [nacl-sdk] Fix nacl sdk example on windows. (Closed)

Created:
4 years, 3 months ago by bradnelson
Modified:
4 years, 3 months ago
Reviewers:
sbc, bradn, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[nacl-sdk] Fix nacl sdk example on windows. BUG=None TEST=None R=sbc@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk BUG=646185 Committed: https://crrev.com/dd9a0933ebd8fad8ba1d70736f5d996ae25d2c03 Cr-Commit-Position: refs/heads/master@{#419332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M native_client_sdk/src/examples/api/vpn_provider/vpn_provider_helper.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
bradn
4 years, 3 months ago (2016-09-16 21:04:21 UTC) #3
sbc
lgtm please add win_nacl_sdk trybot.
4 years, 3 months ago (2016-09-16 21:45:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342353003/1
4 years, 3 months ago (2016-09-16 21:51:14 UTC) #8
sbc
On 2016/09/16 21:51:14, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 3 months ago (2016-09-16 22:01:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 23:52:56 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 23:54:20 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd9a0933ebd8fad8ba1d70736f5d996ae25d2c03
Cr-Commit-Position: refs/heads/master@{#419332}

Powered by Google App Engine
This is Rietveld 408576698