views: provide feedback when editing fails

ui/views/controls/textfield/textfield.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/textfield.h"
 
 #include <string>
 #include <utility>
 
 #include "base/trace_event/trace_event.h"
@@ skipping 667 matching lines @@
   }
 #endif
 
   if (edit_command == ui::TextEditCommand::INVALID_COMMAND)
     edit_command = GetCommandForKeyEvent(event);
 
   if (!handled && IsTextEditCommandEnabled(edit_command)) {
     ExecuteTextEditCommand(edit_command);
     handled = true;
   }
+
+  if (!handled)
+    OnEditFailed();
   return handled;
 }
 
 bool Textfield::OnKeyReleased(const ui::KeyEvent& event) {
   return controller_ && controller_->HandleKeyEvent(this, event);
 }
 
 void Textfield::OnGestureEvent(ui::GestureEvent* event) {
   switch (event->type()) {
     case ui::ET_GESTURE_TAP_DOWN:
@@ skipping 570 matching lines @@
 
   OnBeforeUserAction();
   skip_input_method_cancel_composition_ = true;
   model_->InsertText(new_text);
   skip_input_method_cancel_composition_ = false;
   UpdateAfterChange(true, true);
   OnAfterUserAction();
 }
 
 void Textfield::InsertChar(const ui::KeyEvent& event) {
+  if (read_only()) {
+    OnEditFailed();
+    return;
+  }
+
   // Filter out all control characters, including tab and new line characters,
   // and all characters with Alt modifier (and Search on ChromeOS). But allow
   // characters with the AltGr modifier. On Windows AltGr is represented by
   // Alt+Ctrl or Right Alt, and on Linux it's a different flag that we don't
   // care about.
   const base::char16 ch = event.GetCharacter();
   const bool should_insert_char = ((ch >= 0x20 && ch < 0x7F) || ch > 0x9F) &&
                                   !ui::IsSystemKeyModifier(event.flags());
   if (GetTextInputType() == ui::TEXT_INPUT_TYPE_NONE || !should_insert_char)
     return;
@@ skipping 738 matching lines @@
   if (!HasFocus())
     RequestFocus();
   model_->MoveCursorTo(mouse);
   if (!selection_clipboard_text.empty()) {
     model_->InsertText(selection_clipboard_text);
     UpdateAfterChange(true, true);
   }
   OnAfterUserAction();
 }
 
+void Textfield::OnEditFailed() {
+  PlatformStyle::OnTextfieldEditFailed();
+}
+
 }  // namespace views