views: provide feedback when editing fails

views: provide feedback when editing fails

If a user selects text in a readonly textfield, all editing operations
will silently fail. This change adds a new callback, Textfield::OnKeypressUnhandled,
which serves to provide feedback in this case. Currently feedback is only
implemented for Mac in the form of a system error beep.

BUG=647523
Committed: https://crrev.com/c7da74b7ca322b813d757e0c050aa7fd479ee278
Cr-Commit-Position: refs/heads/master@{#419473}

[Elly Fong-Jones, 2016-09-16 15:44:41]

Description was changed from

==========
views: provide feedback when editing fails

If a user selects text in a readonly textfield, all editing operations
will silently fail. This change adds a new callback, Textfield::OnEditFailed,
which serves to provide feedback in this case. Currently feedback is only
implemented for Mac in the form of a system error beep.

BUG=647523
==========

to

==========
views: provide feedback when editing fails

If a user selects text in a readonly textfield, all editing operations
will silently fail. This change adds a new callback, Textfield::OnEditFailed,
which serves to provide feedback in this case. Currently feedback is only
implemented for Mac in the form of a system error beep.

BUG=647523
==========

[Elly Fong-Jones, 2016-09-16 15:44:41]

ellyjones@chromium.org changed reviewers:
+ sky@chromium.org

[Elly Fong-Jones, 2016-09-16 16:43:06]

sky: ptal? :)

[sky, 2016-09-16 17:34:37]

https://codereview.chromium.org/2342343003/diff/1/ui/views/controls/textfield...
File ui/views/controls/textfield/textfield.h (right):

https://codereview.chromium.org/2342343003/diff/1/ui/views/controls/textfield...
ui/views/controls/textfield/textfield.h:395: // Called whenever an editing
operation fails to provide visual or audio
Why the visual/audio-feedback description? Isn't this more of 'called when a
keyevent is not handled for any reason, including the text-field is supplied a
keyevent and is read-only.

[Elly Fong-Jones, 2016-09-19 11:28:36]

Description was changed from

==========
views: provide feedback when editing fails

If a user selects text in a readonly textfield, all editing operations
will silently fail. This change adds a new callback, Textfield::OnEditFailed,
which serves to provide feedback in this case. Currently feedback is only
implemented for Mac in the form of a system error beep.

BUG=647523
==========

to

==========
views: provide feedback when editing fails

If a user selects text in a readonly textfield, all editing operations
will silently fail. This change adds a new callback,
Textfield::OnKeypressUnhandled,
which serves to provide feedback in this case. Currently feedback is only
implemented for Mac in the form of a system error beep.

BUG=647523
==========

[Elly Fong-Jones, 2016-09-19 11:28:57]

sky: ptal? :)

https://codereview.chromium.org/2342343003/diff/1/ui/views/controls/textfield...
File ui/views/controls/textfield/textfield.h (right):

https://codereview.chromium.org/2342343003/diff/1/ui/views/controls/textfield...
ui/views/controls/textfield/textfield.h:395: // Called whenever an editing
operation fails to provide visual or audio
On 2016/09/16 17:34:36, sky wrote:
> Why the visual/audio-feedback description? Isn't this more of 'called when a
> keyevent is not handled for any reason, including the text-field is supplied a
> keyevent and is read-only.

Done.

[sky, 2016-09-19 15:10:50]

Thanks LGTM

[Elly Fong-Jones, 2016-09-19 15:25:14]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-09-19 15:25:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 16:10:50]

Description was changed from

==========
views: provide feedback when editing fails

If a user selects text in a readonly textfield, all editing operations
will silently fail. This change adds a new callback,
Textfield::OnKeypressUnhandled,
which serves to provide feedback in this case. Currently feedback is only
implemented for Mac in the form of a system error beep.

BUG=647523
==========

to

==========
views: provide feedback when editing fails

If a user selects text in a readonly textfield, all editing operations
will silently fail. This change adds a new callback,
Textfield::OnKeypressUnhandled,
which serves to provide feedback in this case. Currently feedback is only
implemented for Mac in the form of a system error beep.

BUG=647523
==========

[commit-bot: I haz the power, 2016-09-19 16:10:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-19 16:12:43]

Description was changed from

==========
views: provide feedback when editing fails

If a user selects text in a readonly textfield, all editing operations
will silently fail. This change adds a new callback,
Textfield::OnKeypressUnhandled,
which serves to provide feedback in this case. Currently feedback is only
implemented for Mac in the form of a system error beep.

BUG=647523
==========

to

==========
views: provide feedback when editing fails

If a user selects text in a readonly textfield, all editing operations
will silently fail. This change adds a new callback,
Textfield::OnKeypressUnhandled,
which serves to provide feedback in this case. Currently feedback is only
implemented for Mac in the form of a system error beep.

BUG=647523

Committed: https://crrev.com/c7da74b7ca322b813d757e0c050aa7fd479ee278
Cr-Commit-Position: refs/heads/master@{#419473}
==========

[commit-bot: I haz the power, 2016-09-19 16:12:45]

Patchset 2 (id:??) landed as
https://crrev.com/c7da74b7ca322b813d757e0c050aa7fd479ee278
Cr-Commit-Position: refs/heads/master@{#419473}