Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2342333002: Update GN docs to mention is_official_build and ndk_api. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update GN docs to mention is_official_build and ndk_api. is_official_build is the closest approximation to what we'd recommend people ship, and we'll keep tweaking it further toward that goal. I want it to be the first choices people see reading the doc to nudge them to defaulting into that if they don't know better. The familiar old Debug and Release for developers come later. It'd be a fine choice, for instance, for fiddle to build against. I dropped Stripped because that's something is_official_build now does more naturally. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342333002 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2342333002 Committed: https://skia.googlesource.com/skia/+/40efbe85525a4dceefb1ce46c036c01813492602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M site/user/quick/gn.md View 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mtklein_C
4 years, 3 months ago (2016-09-16 13:09:45 UTC) #4
jcgregorio
lgtm
4 years, 3 months ago (2016-09-16 14:14:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342333002/1
4 years, 3 months ago (2016-09-16 14:15:58 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 14:17:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/40efbe85525a4dceefb1ce46c036c01813492602

Powered by Google App Engine
This is Rietveld 408576698