Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 2342313003: [SVGDom] Improved DM sizing (Closed)

Created:
4 years, 3 months ago by f(malita)
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

[SVGDom] Improved DM sizing Rather than always using a 1000x1000 canvas, observe the SVG intrinsic size when available. If the intrinsic size is < 128x128, scale uniformly. R=robertphillips@google.com,stephana@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342313003 Committed: https://skia.googlesource.com/skia/+/bdf3e5c0341884ead2c1fd97084637b37249418a

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -16 lines) Patch
M dm/DMSrcSink.h View 2 chunks +11 lines, -1 line 0 comments Download
M dm/DMSrcSink.cpp View 1 1 chunk +42 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
f(malita)
Annoyingly convoluted due to DM::Src not having a pre-draw virtual.
4 years, 3 months ago (2016-09-16 19:37:53 UTC) #2
robertphillips
lgtm
4 years, 3 months ago (2016-09-16 19:44:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342313003/20001
4 years, 3 months ago (2016-09-17 14:25:33 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-17 14:26:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/bdf3e5c0341884ead2c1fd97084637b37249418a

Powered by Google App Engine
This is Rietveld 408576698