Reenable testTBM2ForSmoke & fix clock sync error on ref build of Chrome on Mac

Reenable testTBM2ForSmoke & fix clock sync error on ref build of Chrome on Mac

The root cause of the failure was that that logic for 
checking whether telemetry should issue backcompat clocksync
use Chrome revision number that is not high enough to 
actually contains the devtool's clocksync API.

This CL fixes it by bumping up the version number used for
checking whether to do backcompat clock sync.

BUG=chromium:646925
BUG=catapult:#2804

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/be85e5fd4bf5793777543eded8f53b47c4241386

[nednguyen, 2016-09-16 10:32:54]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 10:33:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2016-09-16 10:46:31]

nednguyen@google.com changed reviewers:
+ charliea@chromium.org, zhenw@chromium.org

[commit-bot: I haz the power, 2016-09-16 10:46:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 10:46:52]

Dry run: Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[nednguyen, 2016-09-16 10:48:14]

On 2016/09/16 10:46:32, nednguyen wrote:

Mystery solved: the revision of the Mac ref build is 2743 & apparently that is
not high enough to contain Zhen's clock sync devtool API.

It still unclear how this passes in
https://codereview.chromium.org/2347513002/...

[nednguyen, 2016-09-16 10:50:34]

Description was changed from

==========
Reenable testTBM2ForSmoke

BUG=chromium:646925
BUG=catapult:#2804
==========

to

==========
Reenable testTBM2ForSmoke & fix clock sync error on ref build of Chrome on Mac

BUG=chromium:646925
BUG=catapult:#2804
==========

[nednguyen, 2016-09-16 10:50:49]

On 2016/09/16 10:48:14, nednguyen wrote:
> On 2016/09/16 10:46:32, nednguyen wrote:
> 
> Mystery solved: the revision of the Mac ref build is 2743 & apparently that is
> not high enough to contain Zhen's clock sync devtool API.
> 
> It still unclear how this passes in
> https://codereview.chromium.org/2347513002/...

Also unsure how this passes locally..

[nednguyen, 2016-09-16 10:50:53]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 10:51:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 11:13:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 11:13:59]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2016-09-16 11:48:02]

Description was changed from

==========
Reenable testTBM2ForSmoke & fix clock sync error on ref build of Chrome on Mac

BUG=chromium:646925
BUG=catapult:#2804
==========

to

==========
Reenable testTBM2ForSmoke & fix clock sync error on ref build of Chrome on Mac

The root cause of the failure was that that logic for 
checking whether telemetry should issue backcompat clocksync
use Chrome revision number that is not high enough to 
actually contains the devtool's clocksync API.

This CL fixes it by bumping up the version number used for
checking whether to do backcompat clock sync.

BUG=chromium:646925
BUG=catapult:#2804
==========

[nednguyen, 2016-09-16 14:19:04]

On 2016/09/16 10:50:49, nednguyen wrote:
> On 2016/09/16 10:48:14, nednguyen wrote:
> > On 2016/09/16 10:46:32, nednguyen wrote:
> > 
> > Mystery solved: the revision of the Mac ref build is 2743 & apparently that
is
> > not high enough to contain Zhen's clock sync devtool API.
> > 
> > It still unclear how this passes in
> > https://codereview.chromium.org/2347513002/...
> 
> Also unsure how this passes locally..

Updated the documentation, PTAL again

[nednguyen, 2016-09-16 14:23:29]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 14:23:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[charliea (OOO until 10-5), 2016-09-16 14:27:33]

lgtm w/ nits

https://codereview.chromium.org/2342303002/diff/20001/telemetry/telemetry/int...
File telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py
(right):

https://codereview.chromium.org/2342303002/diff/20001/telemetry/telemetry/int...
telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py:182:
if version and int(version) > 2743:
Please add comment that we're not actually sure that this is the right number,
and it probably is something a little higher than this

https://codereview.chromium.org/2342303002/diff/40001/telemetry/telemetry/int...
File telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py
(right):

https://codereview.chromium.org/2342303002/diff/40001/telemetry/telemetry/int...
telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py:182:
# Note, we ain't sure whether 2744 is the correct cut-off point which Chrome
*we aren't

https://codereview.chromium.org/2342303002/diff/40001/telemetry/telemetry/int...
telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py:186:
# the cut-off branch number will need to be pumped up again.
pumped => bumped

[nednguyen, 2016-09-16 14:28:50]

https://codereview.chromium.org/2342303002/diff/40001/telemetry/telemetry/int...
File telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py
(right):

https://codereview.chromium.org/2342303002/diff/40001/telemetry/telemetry/int...
telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py:182:
# Note, we ain't sure whether 2744 is the correct cut-off point which Chrome
On 2016/09/16 14:27:33, charliea wrote:
> *we aren't

Done.

https://codereview.chromium.org/2342303002/diff/40001/telemetry/telemetry/int...
telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py:186:
# the cut-off branch number will need to be pumped up again.
On 2016/09/16 14:27:33, charliea wrote:
> pumped => bumped

Done.

[nednguyen, 2016-09-16 14:28:53]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2016-09-16 14:28:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
charliea@chromium.org
Link to the patchset: https://codereview.chromium.org/2342303002/#ps60001
(title: "nits")

[commit-bot: I haz the power, 2016-09-16 14:29:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 14:58:58]

Description was changed from

==========
Reenable testTBM2ForSmoke & fix clock sync error on ref build of Chrome on Mac

The root cause of the failure was that that logic for 
checking whether telemetry should issue backcompat clocksync
use Chrome revision number that is not high enough to 
actually contains the devtool's clocksync API.

This CL fixes it by bumping up the version number used for
checking whether to do backcompat clock sync.

BUG=chromium:646925
BUG=catapult:#2804
==========

to

==========
Reenable testTBM2ForSmoke & fix clock sync error on ref build of Chrome on Mac

The root cause of the failure was that that logic for 
checking whether telemetry should issue backcompat clocksync
use Chrome revision number that is not high enough to 
actually contains the devtool's clocksync API.

This CL fixes it by bumping up the version number used for
checking whether to do backcompat clock sync.

BUG=chromium:646925
BUG=catapult:#2804

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-09-16 14:59:01]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...