Use a plain FixedArray rather than a SeededNumberDictionary for ValueDeserializer::id_map_.

Use a plain FixedArray rather than a SeededNumberDictionary for ValueDeserializer::id_map_.

In practice this is a dense array, because there is currently no provision
in the format for assigning IDs other than sequentially to every object.
Thus a FixedArray is more efficient than a general dictionary.

BUG=chromium:148757
Committed: https://crrev.com/ca6e40d7ba853319c15196fef3f4536c8b3929fe
Cr-Commit-Position: refs/heads/master@{#39486}

[jbroman, 2016-09-16 20:05:24]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 20:05:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-09-16 20:34:37]

jbroman@chromium.org changed reviewers:
+ cbruni@chromium.org, jkummerow@chromium.org

[commit-bot: I haz the power, 2016-09-16 20:35:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 20:35:07]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-09-16 20:49:37]

lgtm with nits

https://codereview.chromium.org/2342293003/diff/1/src/value-serializer.cc
File src/value-serializer.cc (right):

https://codereview.chromium.org/2342293003/diff/1/src/value-serializer.cc#new...
src/value-serializer.cc:1578: id_map_->get(id) !=
isolate_->heap()->the_hole_value();
nit: use IsTheHole(isolate_)

https://codereview.chromium.org/2342293003/diff/1/src/value-serializer.cc#new...
src/value-serializer.cc:1586: if (value == isolate_->heap()->the_hole_value()) {
nit: use IsTheHole(isolate_)

[jbroman, 2016-09-17 05:00:21]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-09-17 05:00:24]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2342293003/#ps20001
(title: "IsTheHole")

[commit-bot: I haz the power, 2016-09-17 05:00:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-09-17 05:00:51]

https://codereview.chromium.org/2342293003/diff/1/src/value-serializer.cc
File src/value-serializer.cc (right):

https://codereview.chromium.org/2342293003/diff/1/src/value-serializer.cc#new...
src/value-serializer.cc:1578: id_map_->get(id) !=
isolate_->heap()->the_hole_value();
On 2016/09/16 at 20:49:37, Camillo Bruni wrote:
> nit: use IsTheHole(isolate_)

Done.

https://codereview.chromium.org/2342293003/diff/1/src/value-serializer.cc#new...
src/value-serializer.cc:1586: if (value == isolate_->heap()->the_hole_value()) {
On 2016/09/16 at 20:49:37, Camillo Bruni wrote:
> nit: use IsTheHole(isolate_)

Done.

[commit-bot: I haz the power, 2016-09-17 05:45:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-17 05:46:18]

Description was changed from

==========
Use a plain FixedArray rather than a SeededNumberDictionary for
ValueDeserializer::id_map_.

In practice this is a dense array, because there is currently no provision
in the format for assigning IDs other than sequentially to every object.
Thus a FixedArray is more efficient than a general dictionary.

BUG=chromium:148757
==========

to

==========
Use a plain FixedArray rather than a SeededNumberDictionary for
ValueDeserializer::id_map_.

In practice this is a dense array, because there is currently no provision
in the format for assigning IDs other than sequentially to every object.
Thus a FixedArray is more efficient than a general dictionary.

BUG=chromium:148757

Committed: https://crrev.com/ca6e40d7ba853319c15196fef3f4536c8b3929fe
Cr-Commit-Position: refs/heads/master@{#39486}
==========

[commit-bot: I haz the power, 2016-09-17 05:46:19]

Patchset 2 (id:??) landed as
https://crrev.com/ca6e40d7ba853319c15196fef3f4536c8b3929fe
Cr-Commit-Position: refs/heads/master@{#39486}