Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 2342243002: MD History: Fix sync info icon in RTL languages (Closed)

Created:
4 years, 3 months ago by tsergeant
Modified:
4 years, 3 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Fix sync info icon in RTL languages This icon was incorrectly appearing on the right side of the page, when it should appear on the left. BUG=622055 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/cb822998547a76921c0a8ea5572db49fedd71700 Cr-Commit-Position: refs/heads/master@{#419105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M chrome/browser/resources/md_history/app.vulcanized.html View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.html View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tsergeant
4 years, 3 months ago (2016-09-16 03:28:15 UTC) #5
calamity
lgtm
4 years, 3 months ago (2016-09-16 03:51:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342243002/1
4 years, 3 months ago (2016-09-16 03:56:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 04:59:12 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 05:00:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb822998547a76921c0a8ea5572db49fedd71700
Cr-Commit-Position: refs/heads/master@{#419105}

Powered by Google App Engine
This is Rietveld 408576698