Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: chrome/browser/extensions/api/identity/web_auth_flow.h

Issue 2342233004: Change WebAuthFlow to use the new WebContentsObserver navigation notifications. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/identity/web_auth_flow.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_IDENTITY_WEB_AUTH_FLOW_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_IDENTITY_WEB_AUTH_FLOW_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_IDENTITY_WEB_AUTH_FLOW_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_IDENTITY_WEB_AUTH_FLOW_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 void OnAppWindowAdded(AppWindow* app_window) override; 96 void OnAppWindowAdded(AppWindow* app_window) override;
97 void OnAppWindowRemoved(AppWindow* app_window) override; 97 void OnAppWindowRemoved(AppWindow* app_window) override;
98 98
99 // NotificationObserver implementation. 99 // NotificationObserver implementation.
100 void Observe(int type, 100 void Observe(int type,
101 const content::NotificationSource& source, 101 const content::NotificationSource& source,
102 const content::NotificationDetails& details) override; 102 const content::NotificationDetails& details) override;
103 103
104 // WebContentsObserver implementation. 104 // WebContentsObserver implementation.
105 void DidStopLoading() override; 105 void DidStopLoading() override;
106 void DidNavigateMainFrame(
107 const content::LoadCommittedDetails& details,
108 const content::FrameNavigateParams& params) override;
109 void RenderProcessGone(base::TerminationStatus status) override; 106 void RenderProcessGone(base::TerminationStatus status) override;
110 void DidStartProvisionalLoadForFrame(
111 content::RenderFrameHost* render_frame_host,
112 const GURL& validated_url,
113 bool is_error_page,
114 bool is_iframe_srcdoc) override;
115 void DidFailProvisionalLoad(content::RenderFrameHost* render_frame_host,
116 const GURL& validated_url,
117 int error_code,
118 const base::string16& error_description,
119 bool was_ignored_by_handler) override;
120 void DidGetRedirectForResourceRequest( 107 void DidGetRedirectForResourceRequest(
121 const content::ResourceRedirectDetails& details) override; 108 const content::ResourceRedirectDetails& details) override;
122 void TitleWasSet(content::NavigationEntry* entry, bool explicit_set) override; 109 void TitleWasSet(content::NavigationEntry* entry, bool explicit_set) override;
110 void DidStartNavigation(
111 content::NavigationHandle* navigation_handle) override;
112 void DidFinishNavigation(
113 content::NavigationHandle* navigation_handle) override;
123 114
124 void BeforeUrlLoaded(const GURL& url); 115 void BeforeUrlLoaded(const GURL& url);
125 void AfterUrlLoaded(); 116 void AfterUrlLoaded();
126 117
127 Delegate* delegate_; 118 Delegate* delegate_;
128 Profile* profile_; 119 Profile* profile_;
129 GURL provider_url_; 120 GURL provider_url_;
130 Mode mode_; 121 Mode mode_;
131 122
132 AppWindow* app_window_; 123 AppWindow* app_window_;
133 std::string app_window_key_; 124 std::string app_window_key_;
134 bool embedded_window_created_; 125 bool embedded_window_created_;
135 126
136 content::NotificationRegistrar registrar_; 127 content::NotificationRegistrar registrar_;
137 128
138 DISALLOW_COPY_AND_ASSIGN(WebAuthFlow); 129 DISALLOW_COPY_AND_ASSIGN(WebAuthFlow);
139 }; 130 };
140 131
141 } // namespace extensions 132 } // namespace extensions
142 133
143 #endif // CHROME_BROWSER_EXTENSIONS_API_IDENTITY_WEB_AUTH_FLOW_H_ 134 #endif // CHROME_BROWSER_EXTENSIONS_API_IDENTITY_WEB_AUTH_FLOW_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/api/identity/web_auth_flow.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698