Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2342233003: Add a feature-controlled persistence checkbox to geolocation prompts on desktop Views platforms. (Closed)

Created:
4 years, 3 months ago by dominickn
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, msramek+watch_chromium.org, tfarina, raymes+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, mlamouri+watch-permissions_chromium.org, markusheintz_, miu+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Add a feature-controlled persistence checkbox to geolocation prompts on desktop Views platforms. This CL allows geolocation permission prompts to show a checkbox to allow the user to optionally persist their decision. It is intended to use this to gather metrics on whether users are more likely to make a decision on a permission prompt when presented with more information regarding how long the decision will last. Additional tests in the permission layer are added to verify the optional persistence. BUG=632269 Review-Url: https://codereview.chromium.org/2258763002 Cr-Commit-Position: refs/heads/master@{#418189} (cherry picked from commit d4e446a9c0944eb6748eceaf036f94dfc17acbb4) Committed: https://chromium.googlesource.com/chromium/src/+/58c416bd91c9279110d61da469184449365038fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -84 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/permissions/permission_context_base.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/permissions/permission_context_base_unittest.cc View 9 chunks +78 lines, -54 lines 0 comments Download
M chrome/browser/permissions/permission_request.h View 4 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/permissions/permission_request.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/permissions/permission_request_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/permissions/permission_request_impl.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/permissions/permission_request_manager.cc View 3 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permission_prompt_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/permission_prompt_impl.cc View 8 chunks +28 lines, -5 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_browser_test_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_prompt.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dominickn
4 years, 3 months ago (2016-09-16 02:06:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58c416bd91c9279110d61da469184449365038fd.

Powered by Google App Engine
This is Rietveld 408576698