Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 234223002: envsetup: Unbreak android_gyp for a while. (Closed)

Created:
6 years, 8 months ago by Nico
Modified:
6 years, 8 months ago
Reviewers:
michaelbai, Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

envsetup: Unbreak android_gyp for a while. r262292 accidentally broke android_gyp. Unbreak it for a while, by using an env var with a long name that hopefully nobody will refer to from anywhere in the 3-4 weeks it's going to be in the tree. BUG=330631 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/android/envsetup.sh View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Nico
6 years, 8 months ago (2014-04-10 22:19:52 UTC) #1
Nico
(please hit the commit queue button if you think this is fine)
6 years, 8 months ago (2014-04-10 22:24:33 UTC) #2
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 8 months ago (2014-04-10 22:26:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/234223002/1
6 years, 8 months ago (2014-04-10 22:26:45 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 22:26:45 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-10 22:26:46 UTC) #6
Nico
On 2014/04/10 22:26:46, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 8 months ago (2014-04-10 22:31:46 UTC) #7
michaelbai
lgtm
6 years, 8 months ago (2014-04-10 22:34:54 UTC) #8
michaelbai
The CQ bit was checked by michaelbai@chromium.org
6 years, 8 months ago (2014-04-10 22:35:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/234223002/1
6 years, 8 months ago (2014-04-10 22:35:11 UTC) #10
Yaron
On 2014/04/10 22:31:46, Nico wrote: > On 2014/04/10 22:26:46, I haz the power (commit-bot) wrote: ...
6 years, 8 months ago (2014-04-10 22:59:31 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 23:05:39 UTC) #12
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=60799
6 years, 8 months ago (2014-04-10 23:05:39 UTC) #13
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 8 months ago (2014-04-11 00:26:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/234223002/1
6 years, 8 months ago (2014-04-11 00:27:13 UTC) #15
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 00:28:37 UTC) #16
Message was sent while issue was closed.
Change committed as 263143

Powered by Google App Engine
This is Rietveld 408576698