Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2342223003: Merged: [turbofan] Disable LoadElimination completely for asm.js. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.4
Project:
v8
Visibility:
Public.

Description

Merged: [turbofan] Disable LoadElimination completely for asm.js. Revision: b471d4ab5cf48c754d4a3c616e932828a48ab4f8 BUG=v8:5308, chromium:646737 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=ishell@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/c71964e9c77df872fe131be0937abae86d2b10b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/asm/load-elimination.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-16 06:49:07 UTC) #1
Benedikt Meurer
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years, 3 months ago (2016-09-16 06:49:08 UTC) #2
Igor Sheludko
lgtm
4 years, 3 months ago (2016-09-16 06:49:54 UTC) #3
Benedikt Meurer
4 years, 3 months ago (2016-09-16 06:53:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c71964e9c77df872fe131be0937abae86d2b10b9.

Powered by Google App Engine
This is Rietveld 408576698