Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2342203004: Don't include LineLayoutItem.h from SVGTextContentElement.h. (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
eae, fs
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't include LineLayoutItem.h from SVGTextContentElement.h. Committed: https://crrev.com/481cdc9e130c4e68ca389868b1ba05c10b8c796f Cr-Commit-Position: refs/heads/master@{#419274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/core/svg/SVGTextContentElement.h View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTextContentElement.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
mstensho (USE GERRIT)
Another 8 compilation units that will no longer need LayoutObject.h
4 years, 3 months ago (2016-09-16 17:28:43 UTC) #2
fs
lgtm
4 years, 3 months ago (2016-09-16 17:46:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342203004/1
4 years, 3 months ago (2016-09-16 19:13:28 UTC) #6
eae
Thanks Morten!
4 years, 3 months ago (2016-09-16 19:17:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 20:36:43 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 20:38:32 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/481cdc9e130c4e68ca389868b1ba05c10b8c796f
Cr-Commit-Position: refs/heads/master@{#419274}

Powered by Google App Engine
This is Rietveld 408576698