Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2342193002: [DevTools] Migrate AuditsPanel away from SidebarTree. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate AuditsPanel away from SidebarTree. This is a step towards removing SidebarTree and moving all tree outlines into shadow. BUG=none Committed: https://crrev.com/b59bc78ac4e434d27af632d0c70b192dd9c5a5c4 Cr-Commit-Position: refs/heads/master@{#419077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -52 lines) Patch
M third_party/WebKit/LayoutTests/inspector/audits/audits-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js View 7 chunks +26 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/auditsPanel.css View 1 chunk +0 lines, -8 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/audits/auditsSidebarTree.css View 1 chunk +50 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/module.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Could you please take a look?
4 years, 3 months ago (2016-09-15 23:56:27 UTC) #2
caseq
lgtm
4 years, 3 months ago (2016-09-16 00:05:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342193002/1
4 years, 3 months ago (2016-09-16 00:06:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 01:59:12 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 02:01:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b59bc78ac4e434d27af632d0c70b192dd9c5a5c4
Cr-Commit-Position: refs/heads/master@{#419077}

Powered by Google App Engine
This is Rietveld 408576698