Call AddToHomescreenDataFetcher::Observer callbacks when manifest fetch times out

chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
index 8a9ae31d8f112c63df8952de85c03c1fa42c9108..97c70a4496a635d592eca72c248f9e6fd2f68f4f 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
@@ -73,7 +73,7 @@ class AddToHomescreenDataFetcher
                              int minimum_icon_size_in_dp,
                              int ideal_splash_image_size_in_dp,
                              int minimum_splash_image_size_in_dp,
-                             bool check_installable,
+                             bool check_webapk_compatible,
                              Observer* observer);
 
   // Returns a callback which fetches the splash screen image to be stored for
@@ -94,9 +94,12 @@ class AddToHomescreenDataFetcher
 
   ~AddToHomescreenDataFetcher() override;
 
-  // WebContentsObserver
+  // WebContentsObserver:
   bool OnMessageReceived(const IPC::Message& message) override;
 
+  // Called if either InstallableManager or the favicon fetch takes too long.
+  void OnTimeout();

[dominickn, 2016/09/19 05:41:44]

Nit: call this OnDataTimedout() to match data_timeout_timer and the general
naming scheme here.

+
   // Called when InstallableManager finishes looking for a manifest and icon.
   void OnDidPerformInstallableCheck(const InstallableData& data);
 
@@ -112,6 +115,7 @@ class AddToHomescreenDataFetcher
       const favicon_base::FaviconRawBitmapResult& bitmap_result);
 
   // Creates the launcher icon from the given |icon|.
+  void CreateLauncherIcon(const SkBitmap& raw__icon);

[dominickn, 2016/09/19 05:41:44]

Nit: two underscores in variable name.

Nit: make the comment match the variable name.

[pkotwicz, 2016/09/19 23:34:02]

You've got good eyes!

__fixed__

   void CreateLauncherIconInBackground(const SkBitmap& raw__icon);
 
   // Notifies the observer that the shortcut data is all available.
@@ -133,9 +137,9 @@ class AddToHomescreenDataFetcher
   const int minimum_splash_image_size_in_dp_;
 
   // Indicates whether to check WebAPK compatibility.
-  bool check_installable_;
-  bool is_waiting_for_installable_check_;
+  bool check_webapk_compatibility_;
   bool is_waiting_for_web_application_info_;
+  bool did_installable_check_;

[dominickn, 2016/09/19 05:41:44]

Nit: is_installable_check_complete_

   bool is_icon_saved_;
   bool is_ready_;