Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8921)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

Issue 2342183002: Call AddToHomescreenDataFetcher::Observer callbacks when manifest fetch times out (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
index b5d440f4260c78cbb75ab83f848154a25c817702..8b553f76ffeef40b7066bade883d6163205be066 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
@@ -85,7 +85,6 @@ AddToHomescreenDataFetcher::AddToHomescreenDataFetcher(
ideal_splash_image_size_in_dp_(ideal_splash_image_size_in_dp),
minimum_splash_image_size_in_dp_(minimum_splash_image_size_in_dp),
check_installable_(check_installable),
- is_waiting_for_installable_check_(check_installable),
is_waiting_for_web_application_info_(true),
is_icon_saved_(false),
is_ready_(false) {
@@ -163,7 +162,6 @@ void AddToHomescreenDataFetcher::OnDidPerformInstallableCheck(
return;
if (check_installable_) {
- is_waiting_for_installable_check_ = false;
weak_observer_->OnDidDetermineWebApkCompatibility(data.is_installable);
}
@@ -230,11 +228,6 @@ void AddToHomescreenDataFetcher::FetchFavicon() {
if (!web_contents() || !weak_observer_)
return;
- if (check_installable_ && is_waiting_for_installable_check_) {
pkotwicz 2016/09/15 22:44:41 I don't see how this if() statement evaluates to t
- is_waiting_for_installable_check_ = false;
- weak_observer_->OnDidDetermineWebApkCompatibility(false);
- }
-
// Grab the best, largest icon we can find to represent this bookmark.
// TODO(dfalcantara): Try combining with the new BookmarksHandler once its
// rewrite is further along.
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698