Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(233)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/banners/manifest_times_out_test_page.html
Issue
2342183002
:
Call AddToHomescreenDataFetcher::Observer callbacks when manifest fetch times out (Closed)
Patch Set: Merge branch 'reorder_functions' into remove_unneeded_var
Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java
chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
chrome/test/data/banners/manifest_times_out_test_page.html
View unified diff
|
Download patch
« chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
('K') |
« chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 <html>
1 <html>
2 <head>
2 <head>
3 <title>Web app banner test page</title>
3 <title>Web app banner test page</title>
4
<link rel="manifest" href="
manifest_missing.json
" />
4
<link rel="manifest" href="
slow?10000
" />
5 <script src="main.js"></script>
5 <script src="main.js"></script>
6 </head>
6 </head>
7 <body onload="initialize()">
7 <body onload="initialize()">
8 Do-nothing page with a service worker.
8 Do-nothing page with a service worker.
9 </body>
9 </body>
10 </html>
10 </html>
OLD
NEW
« chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
('K') |
« chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
('k') |
no next file »
|
no next file with comments »
Issue 2342183002: Call AddToHomescreenDataFetcher::Observer callbacks when manifest fetch times out (Closed)
Created 4 years, 3 months ago by pkotwicz
Modified 4 years, 3 months ago
Reviewers: Xi Han, dominickn
Base URL:
Comments: 13
This is Rietveld
408576698
Chromium Code Reviews
Issue 2342183002:
Call AddToHomescreenDataFetcher::Observer callbacks when manifest fetch times out (Closed)
