Fix #641162: LayoutInline propagate position changes to abspos descendants

Fix #641162: LayoutInline propagate position changes to abspos descendants

When inline element changed its position inline->abspos, its out-of-flow descendants did not get layout invalidated.
This change forces relayout of out-of-flow descendants on position style change.

BUG=641162
Committed: https://crrev.com/6825fc78a249ee41df165e2a3376e4fdb9ef504b
Cr-Commit-Position: refs/heads/master@{#422331}

[atotic, 2016-09-15 22:13:51]

Description was changed from

==========
Fix #641162: LayoutInline propagate position changes to abspos descendants

BUG=
==========

to

==========
Fix #641162: LayoutInline propagate position changes to abspos descendants

When inline element changed its position inline->abspos, its out-of-flow
descendants did not get layout invalidated.
This change forces relayout of out-of-flow descendants on position style change.

BUG=641162
==========

[atotic, 2016-09-15 22:13:51]

atotic@chromium.org changed reviewers:
+ eae@chromium.org, ikilpatrick@chromium.org

[atotic, 2016-09-15 22:19:26]

Talked this fix through with Ian.

The bug happened with display:inline elements. Their out-of-flow descendants did
not get re-relayout when inline's position changed.

The fix is to find the container element that contained the descendants, and
remove them from the container.

Tricky part was finding the container. If the element's old position was inline,
abs container is inline's element containing block.

The fix fixes the bug. I have not added a test case, should I?

[eae, 2016-09-15 22:32:46]

General approach looks fine, having a test for it to ensure it does whats
expected would be great.

[atotic, 2016-09-27 23:22:55]

On 2016/09/15 at 22:32:46, eae wrote:
> General approach looks fine, having a test for it to ensure it does whats
expected would be great.

I've added the test. Please review.

[eae, 2016-09-30 20:27:57]

LGTM, thank you!

[ikilpatrick, 2016-09-30 23:57:37]

lgtm

[atotic, 2016-10-01 00:01:06]

The CQ bit was checked by atotic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 00:01:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 00:14:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 00:14:02]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[atotic, 2016-10-01 15:06:48]

The CQ bit was checked by atotic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-01 15:06:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 17:08:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 17:08:55]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[atotic, 2016-10-01 20:30:51]

The CQ bit was checked by atotic@chromium.org

[atotic, 2016-10-01 20:30:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2342173002/#ps40001
(title: "80 col rebase")

[commit-bot: I haz the power, 2016-10-01 20:31:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 21:44:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-01 21:45:57]

Description was changed from

==========
Fix #641162: LayoutInline propagate position changes to abspos descendants

When inline element changed its position inline->abspos, its out-of-flow
descendants did not get layout invalidated.
This change forces relayout of out-of-flow descendants on position style change.

BUG=641162
==========

to

==========
Fix #641162: LayoutInline propagate position changes to abspos descendants

When inline element changed its position inline->abspos, its out-of-flow
descendants did not get layout invalidated.
This change forces relayout of out-of-flow descendants on position style change.

BUG=641162

Committed: https://crrev.com/6825fc78a249ee41df165e2a3376e4fdb9ef504b
Cr-Commit-Position: refs/heads/master@{#422331}
==========

[commit-bot: I haz the power, 2016-10-01 21:45:59]

Patchset 3 (id:??) landed as
https://crrev.com/6825fc78a249ee41df165e2a3376e4fdb9ef504b
Cr-Commit-Position: refs/heads/master@{#422331}