Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2342163004: Simplify Attr code in XPathUtil (Closed)

Created:
4 years, 3 months ago by foolip
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, dominicc+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify Attr code in XPathUtil Now that Attr never has childen, a Text node can't have an Attr parent, and so the condition would always return true. BUG=305105 R=tkent@chromium.org Committed: https://crrev.com/8d286e5590f772923dcb884be3c7d7613a97d638 Cr-Commit-Position: refs/heads/master@{#419490}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/core/xml/XPathUtil.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
foolip
4 years, 3 months ago (2016-09-16 23:06:39 UTC) #1
tkent
lgtm
4 years, 3 months ago (2016-09-18 21:24:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342163004/20001
4 years, 3 months ago (2016-09-19 14:21:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 17:15:23 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 17:18:51 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d286e5590f772923dcb884be3c7d7613a97d638
Cr-Commit-Position: refs/heads/master@{#419490}

Powered by Google App Engine
This is Rietveld 408576698