Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2169)

Issue 2342163002: Fix gtk3 build (Closed)

Created:
4 years, 3 months ago by Paweł Hajdan Jr.
Modified:
4 years, 3 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gtk3 build This includes making it work when gtk2 is not installed. BUG=none Committed: https://crrev.com/c3851704203577d7621f79ad286d22eb7f5cf1d5 Cr-Commit-Position: refs/heads/master@{#419200}

Patch Set 1 #

Patch Set 2 : wip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -7 lines) Patch
M build/config/linux/gtk3/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M remoting/host/BUILD.gn View 2 chunks +10 lines, -2 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 2 chunks +10 lines, -2 lines 0 comments Download
M remoting/test/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
Paweł Hajdan Jr.
4 years, 3 months ago (2016-09-15 23:24:50 UTC) #9
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-16 00:32:12 UTC) #12
Lambros
lgtm
4 years, 3 months ago (2016-09-16 01:51:09 UTC) #13
Evan Stade
On 2016/09/16 01:51:09, Lambros wrote: > lgtm gtk2_ui.cc lgtm --- thanks for the fix
4 years, 3 months ago (2016-09-16 17:25:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342163002/20001
4 years, 3 months ago (2016-09-16 17:26:53 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 17:33:10 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 17:35:12 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c3851704203577d7621f79ad286d22eb7f5cf1d5
Cr-Commit-Position: refs/heads/master@{#419200}

Powered by Google App Engine
This is Rietveld 408576698