[sync] Verify existence of the root when loading DirectoryBackingStore

[sync] Verify existence of the root when loading DirectoryBackingStore

Currently, DirectoryBackingStore::VerifyReferenceIntegrity only verifies
that all parent ids are valid. This ignores the case of a single, corrupted
root node, which can happen during first sync. This CL adds a check that the
root node exists with the expected id("r").

R=pavely@chromium.org

BUG=642690
Committed: https://crrev.com/6bc75f3306ecd9d4a3d1839b6afac4cf4c3c8d2b
Cr-Commit-Position: refs/heads/master@{#419040}

[Patrick Noland, 2016-09-15 21:12:46]

The CQ bit was checked by pnoland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 21:13:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patrick Noland, 2016-09-15 21:15:10]

The CQ bit was checked by pnoland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 21:16:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patrick Noland, 2016-09-15 21:16:51]

Patchset #1 (id:1) has been deleted

[Patrick Noland, 2016-09-15 21:45:59]

Description was changed from

==========
[sync] Verify existence of the root when loading DirectoryBackingStore

Currently, DirectoryBackingStore::VerifyReferenceIntegrity only verifies
that all parent ids are valid. This ignores the case of a single, corrupted
root node, which can happen furing first sync. This CL adds a check that the
root node exists with the expected id("r").

R=pavely@chromium.org

BUG=642690
==========

to

==========
[sync] Verify existence of the root when loading DirectoryBackingStore

Currently, DirectoryBackingStore::VerifyReferenceIntegrity only verifies
that all parent ids are valid. This ignores the case of a single, corrupted
root node, which can happen during first sync. This CL adds a check that the
root node exists with the expected id("r").

R=pavely@chromium.org

BUG=642690
==========

[Patrick Noland, 2016-09-15 22:01:21]

Pavel, PTAL

[commit-bot: I haz the power, 2016-09-15 22:07:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 22:07:01]

Dry run: This issue passed the CQ dry run.

[pavely, 2016-09-15 22:50:15]

lgtm

https://codereview.chromium.org/2342133002/diff/20001/components/sync/syncabl...
File components/sync/syncable/directory_backing_store.cc (right):

https://codereview.chromium.org/2342133002/diff/20001/components/sync/syncabl...
components/sync/syncable/directory_backing_store.cc:1645: // This function also
checks that the root node exists in the set.
I would say "that root node with correct id exists...".

https://codereview.chromium.org/2342133002/diff/20001/components/sync/syncabl...
components/sync/syncable/directory_backing_store.cc:1671: if
(ids_set.find(Id::GetRoot().value()) == ids_set.end()) {
nit: Since you are using Id class directly could you include syncable_id.h

[Patrick Noland, 2016-09-15 22:57:45]

The CQ bit was checked by pnoland@chromium.org

[Patrick Noland, 2016-09-15 22:57:45]

The patchset sent to the CQ was uploaded after l-g-t-m from pavely@chromium.org
Link to the patchset: https://codereview.chromium.org/2342133002/#ps40001
(title: "include syncable_id, fix comment")

[commit-bot: I haz the power, 2016-09-15 22:58:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 23:50:32]

Description was changed from

==========
[sync] Verify existence of the root when loading DirectoryBackingStore

Currently, DirectoryBackingStore::VerifyReferenceIntegrity only verifies
that all parent ids are valid. This ignores the case of a single, corrupted
root node, which can happen during first sync. This CL adds a check that the
root node exists with the expected id("r").

R=pavely@chromium.org

BUG=642690
==========

to

==========
[sync] Verify existence of the root when loading DirectoryBackingStore

Currently, DirectoryBackingStore::VerifyReferenceIntegrity only verifies
that all parent ids are valid. This ignores the case of a single, corrupted
root node, which can happen during first sync. This CL adds a check that the
root node exists with the expected id("r").

R=pavely@chromium.org

BUG=642690
==========

[commit-bot: I haz the power, 2016-09-15 23:50:33]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-15 23:52:56]

Description was changed from

==========
[sync] Verify existence of the root when loading DirectoryBackingStore

Currently, DirectoryBackingStore::VerifyReferenceIntegrity only verifies
that all parent ids are valid. This ignores the case of a single, corrupted
root node, which can happen during first sync. This CL adds a check that the
root node exists with the expected id("r").

R=pavely@chromium.org

BUG=642690
==========

to

==========
[sync] Verify existence of the root when loading DirectoryBackingStore

Currently, DirectoryBackingStore::VerifyReferenceIntegrity only verifies
that all parent ids are valid. This ignores the case of a single, corrupted
root node, which can happen during first sync. This CL adds a check that the
root node exists with the expected id("r").

R=pavely@chromium.org

BUG=642690

Committed: https://crrev.com/6bc75f3306ecd9d4a3d1839b6afac4cf4c3c8d2b
Cr-Commit-Position: refs/heads/master@{#419040}
==========

[commit-bot: I haz the power, 2016-09-15 23:52:57]

Patchset 2 (id:??) landed as
https://crrev.com/6bc75f3306ecd9d4a3d1839b6afac4cf4c3c8d2b
Cr-Commit-Position: refs/heads/master@{#419040}