Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2342093002: Change the category of "show braille captions" so it shows up in ChromeVox menus (Closed)

Created:
4 years, 3 months ago by dmazzoni
Modified:
4 years, 3 months ago
Reviewers:
David Tseng
CC:
aboxhall+watch_chromium.org, alemate+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the category of "show braille captions" so it shows up in ChromeVox menus Also fix some Closure compiler warnings that triggered as a result of this change. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/698ce60623b2c67b65d5b33306f93684900b2f28 Cr-Commit-Position: refs/heads/master@{#419193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/keyboard_handler.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/command_store.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dmazzoni
4 years, 3 months ago (2016-09-15 18:54:22 UTC) #3
David Tseng
lgtm
4 years, 3 months ago (2016-09-16 16:45:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2342093002/1
4 years, 3 months ago (2016-09-16 16:45:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 16:55:33 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 16:58:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/698ce60623b2c67b65d5b33306f93684900b2f28
Cr-Commit-Position: refs/heads/master@{#419193}

Powered by Google App Engine
This is Rietveld 408576698