Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2342083003: Subzero, MIPS32: nacl-other-intrinsics-mips merged to original file (Closed)

Created:
4 years, 3 months ago by obucinac
Modified:
4 years, 3 months ago
CC:
native-client-reviews_googlegroups.com, rich_fuhler_imgtec.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero, MIPS32: nacl-other-intrinsics-mips merged to original file With fix related to stack alignment bytes increasing, it is possible to return mips tests from nacl-other-intrinsics-mips to its original place. However, with existing vector test, O2 test had to be turned off. This does not affect anything imortant, because it only tested one case (test_sqrt_ignored). R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=40fc819313132f7d9b26e16c566937840be25a05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -105 lines) Patch
M tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll View 10 chunks +38 lines, -0 lines 0 comments Download
D tests_lit/llvm2ice_tests/nacl-other-intrinsics-mips.ll View 1 chunk +0 lines, -105 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
obucinac
Also, some new tests are added, to test more functionality of genTargetHelperCallFor
4 years, 3 months ago (2016-09-16 16:05:03 UTC) #3
Jim Stichnoth
lgtm
4 years, 3 months ago (2016-09-18 13:50:41 UTC) #4
Jim Stichnoth
4 years, 3 months ago (2016-09-18 13:50:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
40fc819313132f7d9b26e16c566937840be25a05 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698