impl/memory/datastore_query_execution.go - Issue 2342063003: Differentiate between single- and multi- props.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: impl/memory/datastore_query_execution.go

Issue 2342063003: Differentiate between single- and multi- props. (Closed)

Patch Set: Slice is now always a clone. This is marginally worse performance, but a much safer UI. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: impl/memory/datastore_query_execution.go

diff --git a/impl/memory/datastore_query_execution.go b/impl/memory/datastore_query_execution.go

index c5d5bf24b9fac8ba4858f36e9c3f59cbabc2be23..15dfbbca736da3f2d02423a2421d1f1f6fa37b9a 100644

--- a/impl/memory/datastore_query_execution.go

+++ b/impl/memory/datastore_query_execution.go

@@ -71,7 +71,7 @@ func (s *projectionStrategy) handle(rawData [][]byte, decodedProps []ds.Property

if s.distinct != nil {

projectedRaw[i] = rawData[p.suffixIndex]

}

- pmap[p.propertyName] = []ds.Property{decodedProps[p.suffixIndex]}

+ pmap[p.propertyName] = decodedProps[p.suffixIndex]

}

if s.distinct != nil {

if !s.distinct.Add(string(serialize.Join(projectedRaw...))) {

« no previous file with comments | « impl/memory/datastore_index_test.go ('k') | impl/memory/datastore_test.go » ('j') | no next file with comments »