filter/featureBreaker/featurebreaker_test.go - Issue 2342063003: Differentiate between single- and multi- props.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: filter/featureBreaker/featurebreaker_test.go

Issue 2342063003: Differentiate between single- and multi- props. (Closed)

Patch Set: Slice is now always a clone. This is marginally worse performance, but a much safer UI. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: filter/featureBreaker/featurebreaker_test.go

diff --git a/filter/featureBreaker/featurebreaker_test.go b/filter/featureBreaker/featurebreaker_test.go

index 09be8ff8b946ddd5834a637f7b492ededfd7428b..70589974634eed19cbab3f76dc04410b8a9ec686 100644

--- a/filter/featureBreaker/featurebreaker_test.go

+++ b/filter/featureBreaker/featurebreaker_test.go

@@ -27,7 +27,7 @@ func TestBrokenFeatures(t *testing.T) {

c, bf := FilterRDS(c, nil)

ds := datastore.Get(c)

vals := []datastore.PropertyMap{{

- "$key": {datastore.MkPropertyNI(ds.NewKey("Wut", "", 1, nil))},

+ "$key": datastore.MkPropertyNI(ds.NewKey("Wut", "", 1, nil)),

}}

Convey("by specifying an error", func() {

@@ -56,7 +56,7 @@ func TestBrokenFeatures(t *testing.T) {

c, bf := FilterRDS(c, e)

ds := datastore.Get(c)

vals := []datastore.PropertyMap{{

- "$key": {datastore.MkPropertyNI(ds.NewKey("Wut", "", 1, nil))},

+ "$key": datastore.MkPropertyNI(ds.NewKey("Wut", "", 1, nil)),

}}

bf.BreakFeatures(nil, "GetMulti")

So(ds.GetMulti(vals), ShouldEqual, e)

« no previous file with comments | « filter/dscache/dscache_test.go ('k') | filter/txnBuf/query_merger.go » ('j') | no next file with comments »