third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp - Issue 2342053002: binding: Refactors bindings/templates/attributes.cpp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp

Issue 2342053002: binding: Refactors bindings/templates/attributes.cpp. (Closed)

Patch Set: Reverted the replacement from hidden values to private properties. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp

index d83c57b7381912ec4e3443372a4d142ef6f5a23f..57e40bc31cbe429e4e1b649b0f0158cb8013be06 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp

@@ -56,7 +56,9 @@ namespace TestInterface3V8Internal {

static void readonlyStringifierAttributeAttributeGetter(const v8::FunctionCallbackInfo<v8::Value>& info)

{

v8::Local<v8::Object> holder = info.Holder();

TestInterface3* impl = V8TestInterface3::toImpl(holder);

v8SetReturnValueString(info, impl->readonlyStringifierAttribute(), info.GetIsolate());

}