third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp - Issue 2342053002: binding: Refactors bindings/templates/attributes.cpp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp

Issue 2342053002: binding: Refactors bindings/templates/attributes.cpp. (Closed)

Patch Set: Reverted the replacement from hidden values to private properties. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/attributes.cpp ('K') | « third_party/WebKit/Source/bindings/templates/attributes.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp » ('j') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp

index f1e147e6579d339e3c0a45bde101eaaf749dda4d..a06465e3af057032386fce7c7cd2748ce4b1f8c2 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp

@@ -13,11 +13,11 @@

#include "bindings/core/v8/V8DataView.h"

#include "bindings/core/v8/V8Float32Array.h"

#include "bindings/core/v8/V8Float64Array.h"

-#include "bindings/core/v8/V8HiddenValue.h"

#include "bindings/core/v8/V8Int16Array.h"

#include "bindings/core/v8/V8Int32Array.h"

#include "bindings/core/v8/V8Int8Array.h"

#include "bindings/core/v8/V8ObjectConstructor.h"

+#include "bindings/core/v8/V8PrivateProperty.h"

#include "bindings/core/v8/V8SharedArrayBuffer.h"

#include "bindings/core/v8/V8Uint16Array.h"

#include "bindings/core/v8/V8Uint32Array.h"