Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

Issue 2342053002: binding: Refactors bindings/templates/attributes.cpp. (Closed)
Patch Set: Reverted the replacement from hidden values to private properties. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_attributes.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
index 4e48f68253f1883a320f2b9a7d44ac5f3c62de2a..9e6ef6b0f83e58eb155df204b397c63ab9dbeed7 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
@@ -101,8 +101,10 @@ def attribute_context(interface, attribute):
cached_attribute_validation_method = extended_attributes.get('CachedAttribute')
keep_alive_for_gc = is_keep_alive_for_gc(interface, attribute)
- if cached_attribute_validation_method or keep_alive_for_gc:
+ if cached_attribute_validation_method:
includes.add('bindings/core/v8/V8HiddenValue.h')
+ if keep_alive_for_gc:
+ includes.add('bindings/core/v8/V8PrivateProperty.h')
haraken 2016/09/20 15:17:25 Revert this change.
Yuki 2016/09/21 10:29:31 Done.
context = {
'access_control_list': access_control_list(interface, attribute),

Powered by Google App Engine
This is Rietveld 408576698