Outputting chart json for disabled tests.

telemetry/telemetry/internal/results/output_formatter.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from telemetry.value import summary as summary_module
 
 class OutputFormatter(object):
   """A formatter for PageTestResults.
 
   An OutputFormatter takes PageTestResults, formats the results
@@ skipping 15 matching lines @@
     """Formats the given PageTestResults into the output stream.
 
     This will be called once at the end of a benchmark.
 
     Args:
       page_test_results: A PageTestResults object containing all results
          from the current benchmark run.
     """
     raise NotImplementedError()
 
+  def FormatDisabled(self):
+    """Formats disabled results into the output stream.
+
+    This will be called once when a benchmark is run but disabled.
+    """
+    raise NotImplementedError()

[perezju, 2016/09/26 14:42:35]

nit: I would let this one be "pass" as the default implementation, since that's
probably what most output formatters will want to do anyway, and there won't be
a need to override everywhere else.

[eyaich1, 2016/09/26 15:26:54]

Done.

+
   @property
   def output_stream(self):
     return self._output_stream
 
 
 def SummarizePageSpecificValues(page_specific_values):
   """Summarize results appropriately for TBM and legacy benchmarks.
 
   For benchmarks that are timeline-based, we need to summarize not once, but
   twice, once by name and tir_label (default) and again by name only. But for
   benchmarks that are not timeline-based, since no tir_labels are set, we will
   end up duplicating values.
 
   Thus, we only want to summarize once if the benchmark is not timeline-based,
   but twice, using the two different key functions, otherwise.
   """
   # Default summary uses merge_values.DefaultKeyFunc to summarize both by name
   # and tir_label.
   summary = summary_module.Summary(page_specific_values)
   values = summary.interleaved_computed_per_page_values_and_summaries
 
   if any(v.tir_label for v in page_specific_values):
     summary_by_name_only = summary_module.Summary(
         page_specific_values,
         key_func=lambda v: v.name)
     values.extend(
         summary_by_name_only.interleaved_computed_per_page_values_and_summaries
     )
   return values