Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2342003002: Enable the optional permission prompt persistence toggle on grouped infobars (Closed)

Created:
4 years, 3 months ago by dominickn
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, dfalcantara+watch_chromium.org, mlamouri+watch-permissions_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Enable the optional permission prompt persistence toggle on grouped infobars This CL adds support for the feature enabling a persistence toggle on permission prompts to grouped permission infobars. The toggle is only shown if an enabling feature is active. Grouped bars are used exclusively for media permissions, so this change allows the toggle to be shown when a single and multiple media permissions are requested. New Android UI tests for responding to the permission prompts triggered by getUserMedia are added to verify the toggle behaviour. The persistence boolean in media_stream_devices_controller is renamed in preparation for upstreaming it into PermissionRequest. BUG=632269 Review-Url: https://codereview.chromium.org/2254763002 Cr-Commit-Position: refs/heads/master@{#418107} (cherry picked from commit fd008ac9abf59ac99681381b297e00652c285246) Committed: https://chromium.googlesource.com/chromium/src/+/02449fec721e22762d322bc204274677d01bd035

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -38 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/GroupedPermissionInfoBar.java View 5 chunks +16 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java View 4 chunks +5 lines, -15 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/MediaPermissionsTest.java View 1 chunk +244 lines, -0 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.h View 3 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 5 chunks +18 lines, -14 lines 0 comments Download
M chrome/browser/media/media_stream_infobar_delegate_android.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/media/media_stream_infobar_delegate_android.cc View 4 chunks +54 lines, -0 lines 0 comments Download
M chrome/browser/permissions/grouped_permission_infobar_delegate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/permissions/grouped_permission_infobar_delegate.cc View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/android/infobars/grouped_permission_infobar.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/android/infobars/grouped_permission_infobar.cc View 2 chunks +14 lines, -1 line 0 comments Download
A content/test/data/android/media_permissions.html View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (5 generated)
dominickn
4 years, 3 months ago (2016-09-15 04:22:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
02449fec721e22762d322bc204274677d01bd035.

Powered by Google App Engine
This is Rietveld 408576698