Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2341963009: pub site: update dependencies and fix analyzer (Closed)

Created:
4 years, 3 months ago by kevmoo
Modified:
4 years, 1 month ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Patch Set 3 : better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -47 lines) Patch
M app/lib/colored_markdown.dart View 1 chunk +3 lines, -1 line 0 comments Download
M app/lib/upload_signer_service.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M app/pubspec.lock View 1 2 13 chunks +34 lines, -33 lines 0 comments Download
M app/pubspec.yaml View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
M app/test/backend_test_utils.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M app/test/handlers_test_utils.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
kevmoo
4 years, 3 months ago (2016-09-16 15:13:46 UTC) #2
kustermann
https://codereview.chromium.org/2341963009/diff/1/app/pubspec.lock File app/pubspec.lock (left): https://codereview.chromium.org/2341963009/diff/1/app/pubspec.lock#oldcode15 app/pubspec.lock:15: version: "0.27.3" We are using package:analyzer, so you can't ...
4 years, 3 months ago (2016-09-16 16:25:56 UTC) #3
kevmoo
https://codereview.chromium.org/2341963009/diff/1/app/pubspec.lock File app/pubspec.lock (left): https://codereview.chromium.org/2341963009/diff/1/app/pubspec.lock#oldcode15 app/pubspec.lock:15: version: "0.27.3" On 2016/09/16 16:25:56, kustermann wrote: > We ...
4 years, 3 months ago (2016-09-16 16:37:24 UTC) #4
kustermann
lgtm
4 years, 3 months ago (2016-09-16 16:40:18 UTC) #5
kevmoo
Committed patchset #3 (id:40001) manually as d9250d0fd523754153094d1e4f9dbe98494ba901 (presubmit successful).
4 years, 3 months ago (2016-09-16 16:41:35 UTC) #7
kustermann
@Kevin: Did you try running this? It broke the app!
4 years, 1 month ago (2016-11-16 13:20:39 UTC) #8
kevmoo
On 2016/11/16 13:20:39, kustermann wrote: > @Kevin: Did you try running this? It broke the ...
4 years, 1 month ago (2016-11-16 16:32:35 UTC) #9
kustermann
4 years, 1 month ago (2016-11-16 16:46:05 UTC) #10
Message was sent while issue was closed.
On 2016/11/16 16:32:35, kevmoo wrote:
> On 2016/11/16 13:20:39, kustermann wrote:
> > @Kevin: Did you try running this? It broke the app!
> 
> ...and we found out now?

Sure: package:shelf changed the meaning of Request.url.path (which does no
longer have the leading '/') - first I suspected a change in AppEngine until I
realized that there was a pubspec update ...

Powered by Google App Engine
This is Rietveld 408576698