pub site: update dependencies and fix analyzer

update dependencies and fix analyzer

R=kustermann@google.com

Committed: https://github.com/dart-lang/pub-dartlang-dart/commit/d9250d0fd523754153094d1e4f9dbe98494ba901

[kevmoo, 2016-09-16 15:13:46]

kevmoo@google.com changed reviewers:
+ kustermann@google.com

[kustermann, 2016-09-16 16:25:56]

https://codereview.chromium.org/2341963009/diff/1/app/pubspec.lock
File app/pubspec.lock (left):

https://codereview.chromium.org/2341963009/diff/1/app/pubspec.lock#oldcode15
app/pubspec.lock:15: version: "0.27.3"
We are using package:analyzer, so you can't remove it:

  import 'package:analyzer/dart/ast/token.dart';
  ...

Could you add it as an explicit dependency to pubspec.yaml?

[kevmoo, 2016-09-16 16:37:24]

https://codereview.chromium.org/2341963009/diff/1/app/pubspec.lock
File app/pubspec.lock (left):

https://codereview.chromium.org/2341963009/diff/1/app/pubspec.lock#oldcode15
app/pubspec.lock:15: version: "0.27.3"
On 2016/09/16 16:25:56, kustermann wrote:
> We are using package:analyzer, so you can't remove it:
> 
>   import 'package:analyzer/dart/ast/token.dart';
>   ...
> 
> Could you add it as an explicit dependency to pubspec.yaml?

Done.

[kustermann, 2016-09-16 16:40:18]

lgtm

[kevmoo, 2016-09-16 16:41:34]

Description was changed from

==========
update dependencies and fix analyzer
==========

to

==========
update dependencies and fix analyzer

R=kustermann@google.com

Committed:
https://github.com/dart-lang/pub-dartlang-dart/commit/d9250d0fd523754153094d1...
==========

[kevmoo, 2016-09-16 16:41:35]

Committed patchset #3 (id:40001) manually as
d9250d0fd523754153094d1e4f9dbe98494ba901 (presubmit successful).

[kustermann, 2016-11-16 13:20:39]

@Kevin: Did you try running this? It broke the app!

[kevmoo, 2016-11-16 16:32:35]

On 2016/11/16 13:20:39, kustermann wrote:
> @Kevin: Did you try running this? It broke the app!

...and we found out now?

Did you try it first?

I did not run it – I should have asked...

[kustermann, 2016-11-16 16:46:05]

On 2016/11/16 16:32:35, kevmoo wrote:
> On 2016/11/16 13:20:39, kustermann wrote:
> > @Kevin: Did you try running this? It broke the app!
> 
> ...and we found out now?

Sure: package:shelf changed the meaning of Request.url.path (which does no
longer have the leading '/') - first I suspected a change in AppEngine until I
realized that there was a pubspec update ...