Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2341963004: Define SK_DECLARE_LEGACY_CREATE_FROM_FONTDATA. (Closed)

Created:
4 years, 3 months ago by bungeman-chromium
Modified:
4 years, 3 months ago
Reviewers:
bungeman-skia
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Define SK_DECLARE_LEGACY_CREATE_FROM_FONTDATA. Skia is changing a few signatures to use smart pointers in its API. This requires that Chromium be updated to match. This define will keep the old API around while the Skia change is rolling into Chromium. Committed: https://crrev.com/cf6c1bd20618194c526ab0aa1f5780217523da5d Cr-Commit-Position: refs/heads/master@{#419048}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M skia/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
bungeman-chromium
lgtm
4 years, 3 months ago (2016-09-15 20:35:38 UTC) #2
bungeman-skia
lgtm
4 years, 3 months ago (2016-09-15 20:35:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341963004/1
4 years, 3 months ago (2016-09-15 20:45:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 00:15:40 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 00:20:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf6c1bd20618194c526ab0aa1f5780217523da5d
Cr-Commit-Position: refs/heads/master@{#419048}

Powered by Google App Engine
This is Rietveld 408576698