Make NTPTile copyable.

Make NTPTile copyable.

iOS likes to copy things. We'll make it easy for them.

BUG=631990
Committed: https://crrev.com/08b57f8c38e4332deb3ef9a421fd4b93d59634c7
Cr-Commit-Position: refs/heads/master@{#420297}

[sfiera, 2016-09-15 01:28:52]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[sfiera, 2016-09-15 01:29:04]

sfiera@chromium.org changed reviewers:
+ treib@chromium.org

[commit-bot: I haz the power, 2016-09-15 01:29:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 02:26:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 02:26:01]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-09-15 09:10:27]

https://codereview.chromium.org/2341963002/diff/1/components/ntp_tiles/ntp_ti...
File components/ntp_tiles/ntp_tile.h (right):

https://codereview.chromium.org/2341963002/diff/1/components/ntp_tiles/ntp_ti...
components/ntp_tiles/ntp_tile.h:46: NTPTile Copy() const;
Hm, at this point, we might as well just remove the DISALLOW_COPY_AND_ASSIGN and
let the thing be copyable the regular way. (Then we probably could also remove
the move ctor and move assignment implementations.)
WDYT?

[sfiera, 2016-09-21 08:50:16]

Description was changed from

==========
Add NTPTile::Copy().

iOS likes to copy things. We'll make it easy for them.

BUG=631990
==========

to

==========
Make NTPTile copyable.

iOS likes to copy things. We'll make it easy for them.

BUG=631990
==========

[sfiera, 2016-09-21 08:53:09]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 08:53:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sfiera, 2016-09-21 08:56:28]

https://codereview.chromium.org/2341963002/diff/1/components/ntp_tiles/ntp_ti...
File components/ntp_tiles/ntp_tile.h (right):

https://codereview.chromium.org/2341963002/diff/1/components/ntp_tiles/ntp_ti...
components/ntp_tiles/ntp_tile.h:46: NTPTile Copy() const;
On 2016/09/15 09:10:27, Marc Treib wrote:
> Hm, at this point, we might as well just remove the DISALLOW_COPY_AND_ASSIGN
and
> let the thing be copyable the regular way. (Then we probably could also remove
> the move ctor and move assignment implementations.)
> WDYT?

Sure, done. (I think I was channeling google3's extreme implicit-copy avoidance)

[Marc Treib, 2016-09-21 08:58:06]

https://codereview.chromium.org/2341963002/diff/1/components/ntp_tiles/ntp_ti...
File components/ntp_tiles/ntp_tile.h (right):

https://codereview.chromium.org/2341963002/diff/1/components/ntp_tiles/ntp_ti...
components/ntp_tiles/ntp_tile.h:46: NTPTile Copy() const;
On 2016/09/21 08:56:28, sfiera wrote:
> On 2016/09/15 09:10:27, Marc Treib wrote:
> > Hm, at this point, we might as well just remove the DISALLOW_COPY_AND_ASSIGN
> and
> > let the thing be copyable the regular way. (Then we probably could also
remove
> > the move ctor and move assignment implementations.)
> > WDYT?
> 
> Sure, done. (I think I was channeling google3's extreme implicit-copy
avoidance)

We mostly have that in Chromium as well, but in this case it's IMO fine to have
it copyable. You might want to put a "Copy and assign allowed" comment in place
of the DISALLOW_COPY_AND_ASSIGN.

[sfiera, 2016-09-21 09:12:58]

https://codereview.chromium.org/2341963002/diff/1/components/ntp_tiles/ntp_ti...
File components/ntp_tiles/ntp_tile.h (right):

https://codereview.chromium.org/2341963002/diff/1/components/ntp_tiles/ntp_ti...
components/ntp_tiles/ntp_tile.h:46: NTPTile Copy() const;
On 2016/09/21 08:58:06, Marc Treib wrote:
> On 2016/09/21 08:56:28, sfiera wrote:
> > On 2016/09/15 09:10:27, Marc Treib wrote:
> > > Hm, at this point, we might as well just remove the
DISALLOW_COPY_AND_ASSIGN
> > and
> > > let the thing be copyable the regular way. (Then we probably could also
> remove
> > > the move ctor and move assignment implementations.)
> > > WDYT?
> > 
> > Sure, done. (I think I was channeling google3's extreme implicit-copy
> avoidance)
> 
> We mostly have that in Chromium as well, but in this case it's IMO fine to
have
> it copyable. You might want to put a "Copy and assign allowed" comment in
place
> of the DISALLOW_COPY_AND_ASSIGN.

I had to add the default copy constructor explicitly for a compiler check, so I
figure I'll let that stand as the indication that copy is allowed.

[commit-bot: I haz the power, 2016-09-21 10:24:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 10:24:17]

Dry run: This issue passed the CQ dry run.

[sfiera, 2016-09-22 09:26:25]

(ping)

[Marc Treib, 2016-09-22 09:29:49]

Oh sorry, I though I had said "lgtm" already. So, lgtm :)

[sfiera, 2016-09-22 09:36:37]

The CQ bit was checked by sfiera@chromium.org

[sfiera, 2016-09-22 09:36:48]

Figured as much :) Thanks.

[commit-bot: I haz the power, 2016-09-22 09:36:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 10:14:44]

Description was changed from

==========
Make NTPTile copyable.

iOS likes to copy things. We'll make it easy for them.

BUG=631990
==========

to

==========
Make NTPTile copyable.

iOS likes to copy things. We'll make it easy for them.

BUG=631990
==========

[commit-bot: I haz the power, 2016-09-22 10:14:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-22 10:16:31]

Description was changed from

==========
Make NTPTile copyable.

iOS likes to copy things. We'll make it easy for them.

BUG=631990
==========

to

==========
Make NTPTile copyable.

iOS likes to copy things. We'll make it easy for them.

BUG=631990

Committed: https://crrev.com/08b57f8c38e4332deb3ef9a421fd4b93d59634c7
Cr-Commit-Position: refs/heads/master@{#420297}
==========

[commit-bot: I haz the power, 2016-09-22 10:16:32]

Patchset 2 (id:??) landed as
https://crrev.com/08b57f8c38e4332deb3ef9a421fd4b93d59634c7
Cr-Commit-Position: refs/heads/master@{#420297}