Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2341953005: Convert editing/pasteboard/displaced-{,generic-}placeholder.html.html to use w3c test harness (Closed)

Created:
4 years, 3 months ago by yosin_UTC9
Modified:
4 years, 3 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/pasteboard/displaced-{,generic-}placeholder.html.html to use w3c test harness This patch converts "editing/pasteboard/displaced-{,generic-}placeholder.html" to use w3c test harness to simplify test script, and consolidates into "editing/inserting/insert_and_placeholder.html" since these test scripts verifies "insertHTML" command with similar test sample, for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/581331a1cbcd63d67bed571b7093a0861847fd32 Cr-Commit-Position: refs/heads/master@{#419131}

Patch Set 1 : 2016-09-15T18:48:33 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -145 lines) Patch
A third_party/WebKit/LayoutTests/editing/inserting/insert_and_place_holder.html View 1 chunk +18 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/pasteboard/displaced-generic-placeholder.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/pasteboard/displaced-placeholder.html View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/displaced-generic-placeholder-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/displaced-generic-placeholder-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/displaced-placeholder-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/displaced-placeholder-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/displaced-generic-placeholder-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/displaced-generic-placeholder-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/displaced-placeholder-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/displaced-placeholder-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/displaced-generic-placeholder-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/displaced-generic-placeholder-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/displaced-placeholder-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/displaced-placeholder-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
yosin_UTC9
PTAL
4 years, 3 months ago (2016-09-16 05:57:19 UTC) #7
Xiaocheng
lgtm
4 years, 3 months ago (2016-09-16 06:54:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341953005/1
4 years, 3 months ago (2016-09-16 08:28:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 08:33:34 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 08:37:07 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/581331a1cbcd63d67bed571b7093a0861847fd32
Cr-Commit-Position: refs/heads/master@{#419131}

Powered by Google App Engine
This is Rietveld 408576698