Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: chrome/browser/media/webrtc/media_stream_devices_controller.cc

Issue 2341953004: Decouple MediaStreamInfoBarDelegate from GroupedPermissionInfoBarDelegate (Closed)
Patch Set: address review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/media_stream_devices_controller.cc
diff --git a/chrome/browser/media/webrtc/media_stream_devices_controller.cc b/chrome/browser/media/webrtc/media_stream_devices_controller.cc
index b1ab7af408447136fb432924f39adf57d7ac07d5..366ff37373c654a16138bdbda18263aaa75015a3 100644
--- a/chrome/browser/media/webrtc/media_stream_devices_controller.cc
+++ b/chrome/browser/media/webrtc/media_stream_devices_controller.cc
@@ -315,28 +315,6 @@ void MediaStreamDevicesController::PermissionDenied() {
content::MEDIA_DEVICE_PERMISSION_DENIED);
}
-void MediaStreamDevicesController::GroupedRequestFinished(bool audio_accepted,
- bool video_accepted) {
- RecordSinglePermissionAction(
- request_, content::PermissionType::AUDIO_CAPTURE, profile_,
- base::Bind(audio_accepted ? PermissionUmaUtil::PermissionGranted
- : PermissionUmaUtil::PermissionDenied));
- RecordSinglePermissionAction(
- request_, content::PermissionType::VIDEO_CAPTURE, profile_,
- base::Bind(video_accepted ? PermissionUmaUtil::PermissionGranted
- : PermissionUmaUtil::PermissionDenied));
-
- ContentSetting audio_setting =
- audio_accepted ? CONTENT_SETTING_ALLOW : CONTENT_SETTING_BLOCK;
- ContentSetting video_setting =
- video_accepted ? CONTENT_SETTING_ALLOW : CONTENT_SETTING_BLOCK;
- RunCallback(GetNewSetting(CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC,
- old_audio_setting_, audio_setting),
- GetNewSetting(CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA,
- old_video_setting_, video_setting),
- content::MEDIA_DEVICE_PERMISSION_DENIED);
-}
-
bool MediaStreamDevicesController::ShouldShowPersistenceToggle() const {
return PermissionUtil::ShouldShowPersistenceToggle();
}

Powered by Google App Engine
This is Rietveld 408576698