Decouple MediaStreamInfoBarDelegate from GroupedPermissionInfoBarDelegate

chrome/browser/permissions/permission_infobar_delegate.h

Index: chrome/browser/permissions/permission_infobar_delegate.h
diff --git a/chrome/browser/permissions/permission_infobar_delegate.h b/chrome/browser/permissions/permission_infobar_delegate.h
index 1156bb8afeeb05dca2ed1af52ff039b09902aedf..d144fa44df82a9a6c4b8520fa6a47aa4b0c8c617 100644
--- a/chrome/browser/permissions/permission_infobar_delegate.h
+++ b/chrome/browser/permissions/permission_infobar_delegate.h
@@ -26,11 +26,11 @@ class PermissionInfoBarDelegate : public ConfirmInfoBarDelegate {
   using PermissionSetCallback = base::Callback<void(bool, PermissionAction)>;
 
   ~PermissionInfoBarDelegate() override;
-  ContentSettingsType content_setting() const { return content_settings_type_; }
+  virtual std::vector<int> content_setting() const;
 
   // Returns true if the infobar should display a toggle to allow users to
   // opt-out of persisting their accept/deny decision.
-  bool ShouldShowPersistenceToggle() const;
+  virtual bool ShouldShowPersistenceToggle() const;

[dominickn, 2016/09/20 08:01:36]

Should this be made virtual, or should you just check the MIC and CAMERA content
settings types (like it does for geolocation right now)? That may be cleaner.

[lshang, 2016/09/21 03:47:39]

Good idea, have merged two media types into ShouldShowPersistenceToggle() of
parent class PermissionInfoBarDelegate.

Done.

 
   // Sets whether or not a decided permission should be persisted to content
   // settings.