Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3959)

Unified Diff: chrome/browser/resources/md_history/history_toolbar.js

Issue 2341923005: MD WebUI: Make cr-lazy-render get() synchronous (Closed)
Patch Set: Simplify test more Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/history_toolbar.js
diff --git a/chrome/browser/resources/md_history/history_toolbar.js b/chrome/browser/resources/md_history/history_toolbar.js
index c3cc51fd65b7f68a3c95e030d3a6b5242003783e..23c71de7a3bb669a2ba80286ca119425d7803e99 100644
--- a/chrome/browser/resources/md_history/history_toolbar.js
+++ b/chrome/browser/resources/md_history/history_toolbar.js
@@ -100,13 +100,12 @@ Polymer({
/** @private */
onInfoButtonTap_: function() {
- this.$.syncNotice.get().then(function(dropdown) {
- dropdown.positionTarget = this.$$('#info-button-icon');
- // It is possible for this listener to trigger while the dialog is
- // closing. Ensure the dialog is fully closed before reopening it.
- if (dropdown.style.display == 'none')
- dropdown.open();
- }.bind(this));
+ var dropdown = this.$.syncNotice.get();
+ dropdown.positionTarget = this.$$('#info-button-icon');
+ // It is possible for this listener to trigger while the dialog is
+ // closing. Ensure the dialog is fully closed before reopening it.
+ if (dropdown.style.display == 'none')
+ dropdown.open();
},
onClearSelectionTap_: function() {

Powered by Google App Engine
This is Rietveld 408576698