Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2341923004: [USS] Covert kSyncEnableUSSDeviceInfo commandline flag to Feature API (Closed)

Created:
4 years, 3 months ago by Gang Wu
Modified:
4 years, 3 months ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[USS] Covert kSyncEnableUSSDeviceInfo commandline flag to Feature API BUG=647492 Committed: https://crrev.com/3110395e033d82da7dc51d08d16517fe72868a88 Cr-Commit-Position: refs/heads/master@{#419176}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove all use of kSyncEnableUSSDeviceInfo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M components/browser_sync/browser/profile_sync_components_factory_impl.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/sync/driver/sync_driver_switches.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/sync_driver_switches.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Gang Wu
PTAL
4 years, 3 months ago (2016-09-15 23:38:55 UTC) #7
pavely
https://codereview.chromium.org/2341923004/diff/1/components/sync/driver/sync_driver_switches.h File components/sync/driver/sync_driver_switches.h (right): https://codereview.chromium.org/2341923004/diff/1/components/sync/driver/sync_driver_switches.h#newcode19 components/sync/driver/sync_driver_switches.h:19: extern const char kSyncEnableUSSDeviceInfo[]; As a result of this ...
4 years, 3 months ago (2016-09-15 23:50:50 UTC) #8
Gang Wu
all kSyncEnableUSSDeviceInfo got removed. https://codereview.chromium.org/2341923004/diff/1/components/sync/driver/sync_driver_switches.h File components/sync/driver/sync_driver_switches.h (right): https://codereview.chromium.org/2341923004/diff/1/components/sync/driver/sync_driver_switches.h#newcode19 components/sync/driver/sync_driver_switches.h:19: extern const char kSyncEnableUSSDeviceInfo[]; On ...
4 years, 3 months ago (2016-09-16 02:58:56 UTC) #11
pavely
lgtm
4 years, 3 months ago (2016-09-16 04:24:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2341923004/20001
4 years, 3 months ago (2016-09-16 15:54:53 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 16:00:34 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 16:02:08 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3110395e033d82da7dc51d08d16517fe72868a88
Cr-Commit-Position: refs/heads/master@{#419176}

Powered by Google App Engine
This is Rietveld 408576698