third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp - Issue 2341923002: Harmonize FilterEffect::mapRect and mapPaintRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp

Issue 2341923002: Harmonize FilterEffect::mapRect and mapPaintRect (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp

index 35090177a9de1ba15097ae25ccf8d2528674328c..a6a27d700c89c9dde14b17e7621c9add0ef34e47 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEOffset.cpp

@@ -63,13 +63,10 @@ void FEOffset::setDy(float dy)

m_dy = dy;

}

-FloatRect FEOffset::mapRect(const FloatRect& rect, bool forward) const

+FloatRect FEOffset::mapEffect(const FloatRect& rect) const

{

FloatRect result = rect;

- if (forward)

- result.move(getFilter()->applyHorizontalScale(m_dx), getFilter()->applyVerticalScale(m_dy));

- else

- result.move(-getFilter()->applyHorizontalScale(m_dx), -getFilter()->applyVerticalScale(m_dy));

+ result.move(getFilter()->applyHorizontalScale(m_dx), getFilter()->applyVerticalScale(m_dy));

return result;

}