third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp - Issue 2341923002: Harmonize FilterEffect::mapRect and mapPaintRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

Issue 2341923002: Harmonize FilterEffect::mapRect and mapPaintRect (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp b/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

index 70d588f4ded39b32140c35e569a66dfb0939c411..2c1c226694039ee3bde077071a58bd73af1d903e 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp

@@ -50,14 +50,6 @@ FELighting::FELighting(Filter* filter, LightingType lightingType, const Color& l

{

}

-FloatRect FELighting::mapPaintRect(const FloatRect& rect, bool) const

- FloatRect result = rect;

- // The areas affected need to be a pixel bigger to accommodate the Sobel kernel.

- result.inflate(1);

- return result;

sk_sp<SkImageFilter> FELighting::createImageFilter()

{

if (!m_lightSource)