third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-lighting.html - Issue 2341923002: Harmonize FilterEffect::mapRect and mapPaintRect

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-lighting.html

Issue 2341923002: Harmonize FilterEffect::mapRect and mapPaintRect (Closed)

Patch Set: Tests and tweaks Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-gaussianblur-expected.txt ('K') | « third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-gaussianblur-yonly-expected.txt ('k') | third_party/WebKit/LayoutTests/paint/invalidation/filters/effect-reference-repaint-lighting-expected.html » ('j') | third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/text-based-repaint.js"></script>

	3 <script>

	4 if (window.testRunner)

	5 testRunner.dumpAsText();

	6

	7 function repaintTest() {

	8 var things = document.getElementsByClassName("before");

	9 while (things.length)

	10 things[0].classList.remove("before");

	11 }

	12 onload = runRepaintAndPixelTest;

	13 </script>

	14 <style>

	15 .box {

	16 width: 200px;

	17 height: 200px;

	18 margin: 20px;

	19 background-color: rgba(0, 128, 0, 0.01);

	20 filter: url(#lighting);
	Stephen White 2016/09/20 19:46:38 I think we'll need to figure out how to get someth I think we'll need to figure out how to get something other than a solid (and possibly transparent) primitive here. Maybe gradients or something could be used to get some non-uniform normals? fs 2016/09/20 21:50:25 I don't think that's the major problem - that woul Show quoted text On 2016/09/20 at 19:46:38, Stephen White wrote: > I think we'll need to figure out how to get something other than a solid (and possibly transparent) primitive here. Maybe gradients or something could be used to get some non-uniform normals? I don't think that's the major problem - that would rather be to get a partial repaint. I changed to use a gradient and then "clip" that with the SourceGraphic.
	21 }

	22 .before {

	23 background-color: red;

	24 }

	25 </style>

	26 <div class="before box"></div>

	27 <svg width="0" height="0">

	28 <filter id="lighting" x="-0.5" y="-0.5" width="2" height="2">

	29 <feOffset dx="1" dy="1"/>

	30 <feComposite in="SourceGraphic"/>

	31 <feDiffuseLighting surfaceScale="200">

	32 <feDistantLight azimuth="-45"/>

	33 </feDiffuseLighting>

	34 <feColorMatrix values="0 0 0 0 0, 0.33 0.33 0.33 0 0, -0.25 0 0 0.25 0, 0 0 0 1 0"/>

	35 </filter>

	36 </svg>

OLD	NEW