Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.cpp

Issue 2341923002: Harmonize FilterEffect::mapRect and mapPaintRect (Closed)
Patch Set: Baselines (again) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org> 5 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * Copyright (C) 2013 Google Inc. All rights reserved. 7 * Copyright (C) 2013 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 27 matching lines...) Expand all
38 , m_scale(scale) 38 , m_scale(scale)
39 { 39 {
40 } 40 }
41 41
42 FEDisplacementMap* FEDisplacementMap::create(Filter* filter, ChannelSelectorType xChannelSelector, 42 FEDisplacementMap* FEDisplacementMap::create(Filter* filter, ChannelSelectorType xChannelSelector,
43 ChannelSelectorType yChannelSelector, float scale) 43 ChannelSelectorType yChannelSelector, float scale)
44 { 44 {
45 return new FEDisplacementMap(filter, xChannelSelector, yChannelSelector, sca le); 45 return new FEDisplacementMap(filter, xChannelSelector, yChannelSelector, sca le);
46 } 46 }
47 47
48 FloatRect FEDisplacementMap::mapPaintRect(const FloatRect& rect, bool) const 48 FloatRect FEDisplacementMap::mapEffect(const FloatRect& rect) const
49 { 49 {
50 FloatRect result = rect; 50 FloatRect result = rect;
51 result.inflateX(getFilter()->applyHorizontalScale(m_scale / 2)); 51 result.inflateX(getFilter()->applyHorizontalScale(m_scale / 2));
52 result.inflateY(getFilter()->applyVerticalScale(m_scale / 2)); 52 result.inflateY(getFilter()->applyVerticalScale(m_scale / 2));
53 return result; 53 return result;
54 } 54 }
55 55
56 FloatRect FEDisplacementMap::mapInputs(const FloatRect& rect) const
Stephen White 2016/09/20 15:36:19 New repaint test for this node?
fs 2016/09/20 19:14:14 Added a (one) test.
57 {
58 return inputEffect(0)->mapRect(rect);
59 }
60
56 ChannelSelectorType FEDisplacementMap::xChannelSelector() const 61 ChannelSelectorType FEDisplacementMap::xChannelSelector() const
57 { 62 {
58 return m_xChannelSelector; 63 return m_xChannelSelector;
59 } 64 }
60 65
61 bool FEDisplacementMap::setXChannelSelector(const ChannelSelectorType xChannelSe lector) 66 bool FEDisplacementMap::setXChannelSelector(const ChannelSelectorType xChannelSe lector)
62 { 67 {
63 if (m_xChannelSelector == xChannelSelector) 68 if (m_xChannelSelector == xChannelSelector)
64 return false; 69 return false;
65 m_xChannelSelector = xChannelSelector; 70 m_xChannelSelector = xChannelSelector;
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 ts << "[feDisplacementMap"; 154 ts << "[feDisplacementMap";
150 FilterEffect::externalRepresentation(ts); 155 FilterEffect::externalRepresentation(ts);
151 ts << " scale=\"" << m_scale << "\" " 156 ts << " scale=\"" << m_scale << "\" "
152 << "xChannelSelector=\"" << m_xChannelSelector << "\" " 157 << "xChannelSelector=\"" << m_xChannelSelector << "\" "
153 << "yChannelSelector=\"" << m_yChannelSelector << "\"]\n"; 158 << "yChannelSelector=\"" << m_yChannelSelector << "\"]\n";
154 inputEffect(0)->externalRepresentation(ts, indent + 1); 159 inputEffect(0)->externalRepresentation(ts, indent + 1);
155 inputEffect(1)->externalRepresentation(ts, indent + 1); 160 inputEffect(1)->externalRepresentation(ts, indent + 1);
156 return ts; 161 return ts;
157 } 162 }
158 163
159 FloatRect FEDisplacementMap::determineAbsolutePaintRect(const FloatRect& request edRect) const
160 {
161 FloatRect rect = requestedRect;
162 if (clipsToBounds())
163 rect.intersect(absoluteBounds());
164
165 rect = mapPaintRect(rect, false);
166 rect = inputEffect(0)->determineAbsolutePaintRect(rect);
167 rect = mapPaintRect(rect, true);
168 rect.intersect(requestedRect);
169 return rect;
170 }
171
172 } // namespace blink 164 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698