Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp

Issue 2341893002: Don't attempt to revalidate a Resource with a 304 response. (Closed)
Patch Set: Move fix to ResourceFetcher::determineRevalidationPolicy, test to ResourceFetcherTest Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp b/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
index 05646be376de3df3f056119a39d446eed5078488..be3ea6d6a1a7057ed987dd2938d39ea5282866d1 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp
@@ -640,4 +640,26 @@ TEST_F(ResourceFetcherTest, LinkPreloadImageMultipleFetchersAndUse)
EXPECT_FALSE(resource->isPreloaded());
}
+TEST_F(ResourceFetcherTest, Revalidate304)
+{
+ KURL url(ParsedURLString, "http://127.0.0.1:8000/foo.html");
+ Resource* resource = Resource::create(url, Resource::Raw);
+ memoryCache()->add(resource);
+ ResourceResponse response;
+ response.setURL(url);
+ response.setHTTPStatusCode(304);
+ response.setHTTPHeaderField("etag", "1234567890");
+ resource->responseReceived(response, nullptr);
+ resource->finish();
+
+ ResourceFetcher* fetcher = ResourceFetcher::create(ResourceFetcherTestMockFetchContext::create());
+ FetchRequest fetchRequest = FetchRequest(url, FetchInitiatorInfo());
+ Platform::current()->getURLLoaderMockFactory()->registerURL(url, WebURLResponse(), "");
+ Resource* newResource = fetcher->requestResource(fetchRequest, TestResourceFactory(Resource::Raw));
+ fetcher->stopFetching();
+ Platform::current()->getURLLoaderMockFactory()->unregisterURL(url);
+
+ EXPECT_NE(resource, newResource);
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698