Issue 234183002: Toro: Remove chrome feature channel dep from //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 234183002: Toro: Remove chrome feature channel dep from //extensions (Closed)

Created:
6 years, 8 months ago by James Cook

Modified:
6 years, 8 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Toro: Remove chrome feature channel dep from //extensions The existence of stable/beta/dev channel is a Chrome concept. Eliminate the reference to feature_channel.h in //extensions by observing for renderer startup and sending the channel to the renderer in //chrome. This is also one of our last //extensions -> //chrome circular dependencies. BUG=362244 TEST=browser_tests *Extensions* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263314

Patch Set 1 : format (feature-channel) #

Patch Set 2 : remove dep (feature-channel) #

Patch Set 3 : rebase (feature-channel) #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -9 lines)			Patch
M	chrome/browser/extensions/chrome_notification_observer.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/chrome_notification_observer.cc	View		3 chunks	+23 lines, -2 lines	0 comments	Download
M	extensions/DEPS	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	extensions/browser/renderer_startup_helper.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/browser/renderer_startup_helper.cc	View		2 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

James Cook

yoz, PTAL In addition to the existing browser tests I've manually verified (via logging) that ...

6 years, 8 months ago (2014-04-10 22:55:51 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/234183002/60001

6 years, 8 months ago (2014-04-11 15:58:30 UTC) #4

Message was sent while issue was closed.

Change committed as 263314

Expand Messages | Collapse Messages