Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: net/cert/internal/verify_signed_data.cc

Issue 2341803002: Remove CertErrors::Add(); use CertErrors::AddError() instead. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/verify_certificate_chain.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/verify_signed_data.cc
diff --git a/net/cert/internal/verify_signed_data.cc b/net/cert/internal/verify_signed_data.cc
index eab84e379d3dff048d9c8635a127cb899c1102fe..bd0ee60f5ea645f88f8a70c232ed20ee7c6e8a2b 100644
--- a/net/cert/internal/verify_signed_data.cc
+++ b/net/cert/internal/verify_signed_data.cc
@@ -167,7 +167,7 @@ WARN_UNUSED_RESULT bool ParseRsaKeyFromSpki(const der::Input& public_key_spki,
unsigned int modulus_length_bits = BN_num_bits(rsa->n);
if (!policy->IsAcceptableModulusLengthForRsa(modulus_length_bits, errors)) {
- errors->Add(kUnacceptableRsaModulusLength);
+ errors->AddError(kUnacceptableRsaModulusLength);
return false;
}
@@ -276,7 +276,7 @@ WARN_UNUSED_RESULT bool ParseEcKeyFromSpki(const der::Input& public_key_spki,
int curve_nid = EC_GROUP_get_curve_name(EC_KEY_get0_group(ec.get()));
if (!policy->IsAcceptableCurveForEcdsa(curve_nid, errors)) {
- errors->Add(kUnacceptableEcdsaCurve);
+ errors->AddError(kUnacceptableEcdsaCurve);
return false;
}
@@ -292,7 +292,7 @@ bool VerifySignedData(const SignatureAlgorithm& signature_algorithm,
const SignaturePolicy* policy,
CertErrors* errors) {
if (!policy->IsAcceptableSignatureAlgorithm(signature_algorithm, errors)) {
- errors->Add(kUnacceptableSignatureAlgorithm);
+ errors->AddError(kUnacceptableSignatureAlgorithm);
return false;
}
@@ -313,7 +313,7 @@ bool VerifySignedData(const SignatureAlgorithm& signature_algorithm,
if (!DoVerify(signature_algorithm, signed_data, signature_value,
public_key.get())) {
- errors->Add(kSignatureVerificationFailed);
+ errors->AddError(kSignatureVerificationFailed);
return false;
}
« no previous file with comments | « net/cert/internal/verify_certificate_chain.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698